Update python version in DockerFile to 3.10.8-slim-bullseye #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
approved these changes
Nov 30, 2022
Contributor
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
Thank you so much @bidoubiwa for this PR ❤️
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chromedriverversion required by docs-scraper was not compatible with the chromedriver version in the previous python image3.8.4in the DockerFile.Updating to latest
python:3.10.8-slim-bullseyefixes this issue.Additionally, the
requestspackage is not a standard library so it should be explicitly added to the Pipfile.We did not update to
python:3.11.0-slim-bullseyebecause selenium is using a package that is not compatible with 3.11. This will be fixed in another issue. See #285