Skip to content

Fix: Remove fullscreen fix for Chrome versions <17 (fix #2644)#2971

Closed
swashbuck wants to merge 1 commit intomediaelement:masterfrom
swashbuck:issue/2644
Closed

Fix: Remove fullscreen fix for Chrome versions <17 (fix #2644)#2971
swashbuck wants to merge 1 commit intomediaelement:masterfrom
swashbuck:issue/2644

Conversation

@swashbuck
Copy link

Fixes #2644

  • Removes the fullscreen fix for Chrome versions <17.
  • This prevents modern Chrome from exiting fullscreen when 1) viewing in an iframe and 2) viewing at under 100% zoom level.

@swashbuck swashbuck changed the title Remove fullscreen fix for Chrome version <17 (fix #2644) Remove fullscreen fix for Chrome versions <17 (fix #2644) Sep 3, 2024
swashbuck added a commit to adaptlearning/adapt-contrib-media that referenced this pull request Sep 3, 2024
joe-allen-89 pushed a commit to adaptlearning/adapt-contrib-media that referenced this pull request Jul 28, 2025
* Remove memory leak in Internet Explorer workaround, remove mep.less

* Removed 'killContextMenuTimer override to remove global delete' since it no longer exists

* Update base mediaelement JS and Less files

* Remove Flash player

* Temporarily remove overrides, add SVG asset and legacy Less (TBD if we'll need it)

* Update pluginType to rendererName, comment out event listeners for testing purposes

* Config: use legacy prefix, set icon asset location

* Added fix from mediaelement/mediaelement#2969

* Add readme to libraries

* Readme update

* Switch to new namespace mejs__

* Fix container height

* Remove .me-plugin references

* Update Less, remove bug fix for CC button language selector still appearing when toggleCaptionsButtonWhenOnlyOne: true

* Update onPlayerReady/success callback with correct new params, change startLanguage to autoplayCaptionLanguage, move startVolume, partially fix mediaCaptionsChange

* Add documentation around onPlayerReady / success callback

* Documentation update

* Replace method calls to incorrect object

* Fix remove

* Fix setupPlayPauseToggle() and related methods

* Remove mediaelementplayer-legacy.less and will re-add if needed

* Remove unused assets and styles

* Remove jumpforward/skipback assets/styles

* Remove Vimeo scripts and styles

* Fullscreen sizing fix

* Fix onCaptionsChanged

* Minor edits/comments

* Remove buildfullscreen override, update pluginType to rendererName

* Add loadPlugins, speed plugin

* Add jumpforward and skipback features, update loadPlugins() to display error messages

* Fix plugin icons, add readme

* Remove commented code

* Button icon fixes

* Fix poster size when iPhoneUseNativeControls: true

* Fix for #239

* Fix for firefox fullscreen api

* #250 Allow use of aria-pressed on closed captions button

* Remove fullscreen fix for Chrome version <17. Apply PR: mediaelement/mediaelement#2971

* Comments

* Fix missing bracket

* Force the default language so that the aria-label can be localised from Adapt

* Use dynamic import for mejs plugins, remove loadPlugins()

* Remove promise from plugin import

* Remove bug Fix for touch devices to override standard hover event

* Remove Bug fix for missing control icons on iOS touch devices

* Remove side padding on time elements

* Remove bug fix due to fixed pixel size preventing iOS from changing orientation without scaling

* Update mediaelement-fullscreen-hook.js to ES6 syntax

* Update hasTouch to use device.touch instead of relying on mejs

* Move addMejsButtonClass()

* Comment out setupPlayPauseToggle() functionality as it seems to just break playing on touch devices and may no longer be needed

* Rework plugin loading

* Move setting up model options to setupModelOptions()

* Move fullscreen hook to main overrides file

* fix client side library loading

* Reversion

* Disable keyboard actions

* Enable keyboard but still remove default keyActions

* Remove unused code

* Remove libraries/mediaelement-and-player from wait queue

* Update readme and example.json

* Remove unnecessary vendor prefixes from fullscreen hook

* Update readme with notes on vimeo/youtube

* Fix: Default seek, event.target, import await, forward scrubbing, fullscreen inview (#311)

* Move plugin Less files into main less directory to prevent issues when using build includes[]

* Restore executable permissions for adapt-contrib-media.js

* Restore executable permissions for README.md

* Update package description to remove Flash reference

* Remove transcript.pdf

* Rework plugin overrides, add plugin section to readme

* Add source ref for mediaelement-and-player.js

* Update mejs__container background to transparent

* Rework sources check

* YouTube/Vimeo check (WIP)

* Update MediaElement.js from 7.0.5 to 7.0.7, readme updates for markdownlint

* Check for YouTube or Vimeo URLs

* Add default landscape width and height to template, do not set width and height when using iPhoneUseNativeControls

* Remove part of PR #320 to fix backwards scrubbing bug

* Readme: link to specific tagged version of mediaelement-and-player.js

* Add shouldSetSize to determine if width / height should be set as a <video> attribute

* Remove unnecessary parentheses

* Fix Skip to transcript button visibility

* Bump FW version to 5.46.10 for .visually-hidden-focusable usage

* Fix FW version

---------

Co-authored-by: Oliver Foster <[email protected]>
@Cerdic
Copy link

Cerdic commented Jul 29, 2025

also fixes #2919

@Cerdic Cerdic mentioned this pull request Jul 29, 2025
@swashbuck swashbuck changed the title Remove fullscreen fix for Chrome versions <17 (fix #2644) Fix: Remove fullscreen fix for Chrome versions <17 (fix #2644) Oct 9, 2025
@digitas-git
Copy link
Collaborator

Thanks for the PR @swashbuck ! This is now included in https://github.com/mediaelement/mediaelement/releases/tag/7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fullscreen on chrome doesn't work if you're in iframe and your zoom level is not 100%

3 participants

Comments