Fix for w3c validation error in volume slider#2818
Merged
digitas-git merged 1 commit intomediaelement:masterfrom Jul 9, 2021
Merged
Fix for w3c validation error in volume slider#2818digitas-git merged 1 commit intomediaelement:masterfrom
digitas-git merged 1 commit intomediaelement:masterfrom
Conversation
…rizontal) because of w3c validation error
Contributor
Author
|
Hi, is there anything I can do to to improve this pull request? Something I did wrong? Or is there any other reason not to merge this PR? Please let me know. |
Collaborator
|
@jenemde Thanks a lot for contributing to mediaelementjs. I've merged this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the error mentioned in
#2801
Short summary:
The Nu Html Checker (https://validator.w3.org/nu/about.html) which does not check the source code but the generated code ("Check serialized DOM of current page") throws the error message "Attribute href not allowed on element a at this point." It's in the volume slider, where href ist not allowed in an element with role="slider".
In this pull request the href="javascript:void(0)" is removed from vertical and horizontal volume sliders.