You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tried my best and the only this I could suspect is the Clang version itself. I was able to run this on Fedora 38 (which had Clang 16), but with Fedora 39 (has Clang 17), it no longer works. I'll probably try building it in a VM if possible to check what is happening.
Seems like a Clang issue to me. Seems to build fine on Lubuntu LTS (has Clang 16) but not on Fedora 39 (Clang 17). I'm not sure how Flutter (or CMake) builds these plugins so I'll have to figure that out.
I mean it does, everyone builds their app compatible with Ubuntu LTS like 75% of the time, it's no wonder. It's also hard to test with multiple distros in multiple configuration. Gotta give this some time since Fedora 39 was just released.
We do not provide our own libmpv binaries for GNU/Linux, unlike other platforms (probably we may have static builds sometime in future; contributions welcomed).
It does not matter to me how one installs libmpv on their system. If you're using a GNU/Linux distribution, you must know in & out of your operating system & not expect it from me (& I don't know in this case). Like I said above, there's no hard & fast rule. I don't care, if you:
Compile libmpv from scratch & then use it with package:media_kit.
Install libmpv from any package manager & then use it with package:media_kit.
In this case, better option might be to reach out to maintainers of the libmpv package for Fedora etc... wherever you are installing it from (it's not us).
On other conventional platforms, we provide our own standalone binaries which are bundled along with the application.
Activity
alexmercerind commentedon Nov 15, 2023
Don't use Flutter from snap... if you are.
zyrouge commentedon Nov 15, 2023
I am not using Flutter from Snap.
alexmercerind commentedon Nov 15, 2023
Then you're on your own... our CI passes.
zyrouge commentedon Nov 15, 2023
Could you hint what could be the possible issue? Is it with flutter or some other tooling like clang?
zyrouge commentedon Nov 15, 2023
Tried my best and the only this I could suspect is the Clang version itself. I was able to run this on Fedora 38 (which had Clang 16), but with Fedora 39 (has Clang 17), it no longer works. I'll probably try building it in a VM if possible to check what is happening.
alexmercerind commentedon Nov 15, 2023
I don't really know man about this ... so much can be different across Linux distributions, there's no hard & fast rule.
Do share us any details if you find, we'll add to README.
Thanks!
zyrouge commentedon Nov 16, 2023
Seems like a Clang issue to me. Seems to build fine on Lubuntu LTS (has Clang 16) but not on Fedora 39 (Clang 17). I'm not sure how Flutter (or CMake) builds these plugins so I'll have to figure that out.
zyrouge commentedon Nov 16, 2023
I can also confirm that Flutter itself works on both Clang 16 and 17.
[-]Error when building on Linux[/-][+]Error when building on Fedora[/+][-]Error when building on Fedora[/-][+]Error when building on Fedora 39[/+]iapicca commentedon Nov 18, 2023
@alexmercerind
of course your CI passes, it tests on ubuntu!
zyrouge commentedon Nov 18, 2023
I mean it does, everyone builds their app compatible with Ubuntu LTS like 75% of the time, it's no wonder. It's also hard to test with multiple distros in multiple configuration. Gotta give this some time since Fedora 39 was just released.
alexmercerind commentedon Nov 18, 2023
First of all, I don't think this issue relates to flutter/flutter.
Certainly someone using Fedora knows better about Fedora (& has better opportunity to figure out) than I do.
Comment on #594:
We do not provide our own libmpv binaries for GNU/Linux, unlike other platforms (probably we may have static builds sometime in future; contributions welcomed).
It does not matter to me how one installs libmpv on their system. If you're using a GNU/Linux distribution, you must know in & out of your operating system & not expect it from me (& I don't know in this case). Like I said above, there's no hard & fast rule. I don't care, if you:
In this case, better option might be to reach out to maintainers of the libmpv package for Fedora etc... wherever you are installing it from (it's not us).
On other conventional platforms, we provide our own standalone binaries which are bundled along with the application.
Thanks!
alexmercerind commentedon Nov 18, 2023
@zyrouge,
You can try to add pthread below this line locally:
media-kit/media_kit_native_event_loop/src/CMakeLists.txt
Line 65 in 0ab6b10
See if that works.
As such:
target_link_libraries( ${TARGET_NAME} PRIVATE PkgConfig::mpv pthread )zyrouge commentedon Nov 19, 2023
That didn't change anything in the logs,
TechComet commentedon Nov 19, 2023
zyrouge commentedon Nov 19, 2023
Add the
--verbosefor more explicit logs. This way we can see it's the same error.femalemonkeyman commentedon Dec 11, 2023
It's not the clang version, I am now having this issue on Arch linux with clang 16
femalemonkeyman commentedon Dec 11, 2023
If the offending lines -D-pthread are removed from the ninja build file you can manually run ninja to build and it builds successfully
CosmicRaptor commentedon May 3, 2024
Would like to add that this is still an issue on fedora 40(Clang 18)
The merged PR fixes it, I hope you release it soon on pub.dev
Thanks!
TechComet commentedon May 4, 2024
work on Fedora
TechComet commentedon May 4, 2024
youtube, vimeo work on dart_vlc but not work on media-kit