Skip to content

Fix site build on Windows#2009

Merged
wooorm merged 1 commit intomdx-js:mainfrom
userzimmermann:zimmermann/absolute-imports
Apr 11, 2022
Merged

Fix site build on Windows#2009
wooorm merged 1 commit intomdx-js:mainfrom
userzimmermann:zimmermann/absolute-imports

Conversation

@userzimmermann
Copy link
Copy Markdown
Contributor

It's redundant & causes Windows-incompatibility for absolute paths, because drive letters are misinterpreted as URL protocols

Solves #2008

It's redundant & causes Windows-incompatibility for absolute paths,
because drive letters are misinterpreted as URL protocols
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/91Q4FPPpckxUWWrSUU4HoxFvsJ6A
✅ Preview: https://mdx-git-fork-userzimmermann-zimmermann-absolute-imports-mdx.vercel.app

@wooorm
Copy link
Copy Markdown
Member

wooorm commented Apr 9, 2022

Hmm if I recall, these functions are needed for something, though I've indeed seen the problem you get on Windows on CI. I'll look into this some more when I'm behind a computer again on Monday to investigate, though a green CI is a good sign, thanks!

@userzimmermann
Copy link
Copy Markdown
Contributor Author

though a green CI is a good sign

It actually doesn't affect current CI—since docs building is not tested; which #2013 would change. Yet, I'm still pondering if the latter is worth the additional CI running time …

@wooorm
Copy link
Copy Markdown
Member

wooorm commented Apr 11, 2022

It actually doesn't affect current CI

The full build still runs in CI tho, meaning that unix works!

Whoops, you’re right, I thought it did (and I would want it to again, when we can move past Node 14)

@wooorm wooorm changed the title Don't convert fileURLToPath() for import() Fix site build on Windows Apr 11, 2022
@wooorm wooorm merged commit acd4943 into mdx-js:main Apr 11, 2022
@wooorm wooorm added 🕸 area/website This affects the website 💪 phase/solved Post is done labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕸 area/website This affects the website 💪 phase/solved Post is done

Development

Successfully merging this pull request may close these issues.

2 participants