Fix resolve base in esbuild loader #1854
Conversation
Closes GH-1821. Related-to: wooorm/xdm@db74ddc
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/3oQWbHXM47W2rPQu5Xb5h1NzYTga |
This comment has been minimized.
This comment has been minimized.
packages/esbuild/lib/index.js
Outdated
| */ | ||
|
|
||
| import assert from 'node:assert' | ||
| import {promises as fs} from 'fs' |
There was a problem hiding this comment.
Would it make sense for fs to also have a node: prefix?
There was a problem hiding this comment.
Good point, I’ll remove the node: prefixes.
There was some reason why I didn’t apply them here (they are in xdm). Perhaps due to CRA or Next or so?
There was a problem hiding this comment.
hmm, it’s a bit inconsistent now anyway. I’ve made it more consistent. esbuild and the node loader probably run in a Node version that support it. I’ve “downgraded” one instance of MDX core though.
wooorm
added
🐛 type/bug
Closes GH-1821.
Related-to: wooorm/xdm@db74ddc