Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Adding an example for overscroll-behavior-y#2448

Merged
NiedziolkaMichal merged 8 commits intomdn:mainfrom
meghannfh:main
Feb 24, 2023
Merged

Adding an example for overscroll-behavior-y#2448
NiedziolkaMichal merged 8 commits intomdn:mainfrom
meghannfh:main

Conversation

@meghannfh
Copy link
Copy Markdown
Contributor

Description

Added css example to demonstrate overscroll-behavior isolated to only the y-axis.

Motivation

Example includes scrolling on both axis that allows the viewer to better visually compare scrolling behavior when it is isolated to just the y-axis.

Additional details

There is not an existing example

Related issues and pull requests

@github-actions
Copy link
Copy Markdown

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@meghannfh
Copy link
Copy Markdown
Contributor Author

meghannfh commented Feb 22, 2023

@NiedziolkaMichal Just wondering if you might be able to give me some insight on this.
I noticed there was an issue with this PR. Is there any action required on my end? I noticed something regarding the css-lint.

Copy link
Copy Markdown
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Thanks for adding this example.

@NiedziolkaMichal
Copy link
Copy Markdown
Member

@meghannfh Unfortunately, you need to sign your commits, so we are able to merge them with the main branch.
On how to do that, please check GPG commit signature verification and Retroactively Sign Git Commits. Plenty of repositories require commits to be signed, so this is something you will need in the future anyway.

@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 23, 2023
94 tasks
@meghannfh
Copy link
Copy Markdown
Contributor Author

meghannfh commented Feb 24, 2023

@meghannfh Unfortunately, you need to sign your commits, so we are able to merge them with the main branch. On how to do that, please check GPG commit signature verification and Retroactively Sign Git Commits. Plenty of repositories require commits to be signed, so this is something you will need in the future anyway.

Thanks for the info. I've just tried pushing a new commit with a GPG signature but for some reason I'm not seeing it reflected here or on my fork of the repo...
Screen Shot 2023-02-23 at 20 29 39

Or am I needing to somehow go back and sign all past commits?

@NiedziolkaMichal
Copy link
Copy Markdown
Member

@bsmth Has lifted the GPG signing requirement, so we are good to go. Thank you for your contribution.

@NiedziolkaMichal NiedziolkaMichal merged commit ae0eab5 into mdn:main Feb 24, 2023
@github-actions
Copy link
Copy Markdown

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants