Adding an example for overscroll-behavior-x#2442
Conversation
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
NiedziolkaMichal
left a comment
NiedziolkaMichal
left a comment
There was a problem hiding this comment.
Thanks a lot for this example, it looks good. I have added some comments about how I think it could be improved.
doanaminh
left a comment
doanaminh
left a comment
There was a problem hiding this comment.
Made changes as requested by @sideshowbarker.
doanaminh
left a comment
doanaminh
left a comment
There was a problem hiding this comment.
Completed changes required to pass checks.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
doanaminh
left a comment
doanaminh
left a comment
There was a problem hiding this comment.
3rd attempt at getting changes fixed and rebasing the branch to get ready to merge.
|
It looks good :) Just fix those two eslint errors and we can merge: |
|
Okay, I deleted the whitespace so hopefully, it can merge this time! |
|
Thank you for your contribution, everything looks good. |
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
2 participants
Description
Added another dimension to the existing overscroll-behavior example.
Isolated only the x-axis to emphasize that the overscroll-behavior property should only work in one dimension.
Motivation
Created an example with 2 dimensions to visually emphasize the effects of overscroll-behavior-x.
Additional details
There was not an existing example.
Related issues and pull requests