Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

feat(css): Add example of :modal#2316

Merged
sideshowbarker merged 3 commits intomainfrom
modal
Jul 22, 2023
Merged

feat(css): Add example of :modal#2316
sideshowbarker merged 3 commits intomainfrom
modal

Conversation

@NiedziolkaMichal
Copy link
Copy Markdown
Member

This PR adds interactive example to :modal.

image

@bsmth bsmth changed the title modal Add CSS :modal pseudo class Dec 7, 2022
@github-actions github-actions Bot added the idle Issues and pull requests with no activity for three months. label Jan 7, 2023
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 10, 2023
94 tasks
@NiedziolkaMichal NiedziolkaMichal changed the title Add CSS :modal pseudo class feat(css): Add example of :modal Feb 26, 2023
@NiedziolkaMichal NiedziolkaMichal removed depends on shadow DOM fix idle Issues and pull requests with no activity for three months. labels Feb 26, 2023
@github-actions github-actions Bot added the idle Issues and pull requests with no activity for three months. label Mar 29, 2023
Comment thread live-examples/css-examples/pseudo-class/modal.html Outdated
@sideshowbarker
Copy link
Copy Markdown
Member

At https://github.com/mdn/interactive-examples/actions/runs/5632002837/job/15259572637?pr=2316#step:6:11 there is a CI failure:

8:1 ✖ Unexpected unknown pseudo-class selector ":modal" selector-pseudo-class-no-unknown

…but the reason for that is, https://github.com/mdn/interactive-examples/blob/1d69481229781284b699d4e7ea118b8dae218939/package.json#L50C24-L50C31 shows that we may be using an old version of stylelint — version 14.16.1 from Dec 29, 2022 — and we instead need to be using at least version 15.6.1 from May 3, 2023, which contains this fix:

Fixed: selector-pseudo-class-no-unknown false positive for :modal (#6811)

@sideshowbarker sideshowbarker merged commit 173563a into main Jul 22, 2023
@sideshowbarker sideshowbarker deleted the modal branch July 22, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

idle Issues and pull requests with no activity for three months.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants