Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

feat(css): Add example of ::backdrop#2175

Merged
estelle merged 4 commits intomdn:mainfrom
NiedziolkaMichal:backdrop-marker
Jul 26, 2023
Merged

feat(css): Add example of ::backdrop#2175
estelle merged 4 commits intomdn:mainfrom
NiedziolkaMichal:backdrop-marker

Conversation

@NiedziolkaMichal
Copy link
Copy Markdown
Member

@NiedziolkaMichal NiedziolkaMichal commented Jun 11, 2022

This PR adds an interactive example for a ::backdrop.

image

image

@wbamberg
Copy link
Copy Markdown
Contributor

Does ::backdrop depend on the shadow DOM fix? The button doesn't work when I push it, and I get an error on the console:

Uncaught TypeError: can't access property "addEventListener", showDialogBtn is null

@NiedziolkaMichal
Copy link
Copy Markdown
Member Author

NiedziolkaMichal commented Jun 30, 2022

Yes :/ I was testing them on BOB with iframe and didn't realize that it will fail on a current build.

I think all examples with JS tab will fail, so could you skip those PRs for now? I will try to move pseudo classes without any dependency, like a :marker, to a separate PRs.

@NiedziolkaMichal NiedziolkaMichal changed the title Backdrop & Marker Backdrop Jun 30, 2022
@github-actions github-actions Bot added the idle Issues and pull requests with no activity for three months. label Dec 22, 2022
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 10, 2023
94 tasks
@NiedziolkaMichal NiedziolkaMichal removed depends on shadow DOM fix idle Issues and pull requests with no activity for three months. labels Feb 28, 2023
@NiedziolkaMichal NiedziolkaMichal changed the title Backdrop feat(css): Add example of ::backdrop Feb 28, 2023
@github-actions github-actions Bot added the idle Issues and pull requests with no activity for three months. label Mar 31, 2023
Copy link
Copy Markdown
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is working for me. Thanks!

@estelle
Copy link
Copy Markdown
Member

estelle commented Jul 25, 2023

@wbamberg is this ok to merge?

@wbamberg
Copy link
Copy Markdown
Contributor

I haven't tested it lately but it ought to work now @NiedziolkaMichal 's fix to avoid shadow DOM is in, so if it works for you I'm sure it will be fine.

@github-actions github-actions Bot removed the idle Issues and pull requests with no activity for three months. label Jul 25, 2023
@estelle estelle merged commit 6355aad into mdn:main Jul 26, 2023
@pcjmfranken
Copy link
Copy Markdown

The ::marker example first removed by 294cd88 and later restored by f137050 has sadly fallen victim to squash merging: https://developer.mozilla.org/en-US/docs/Web/CSS/::marker (RIP in pieces).

This method can seriously mess things up in several annoying and unobvious ways. In this particular case it has allowed for an older change to overwrite a more recent conflicting one because their parent branches/PRs were merged in the opposite order.

Re-merging PR #2200 would probably produce the cleanest and best traceable fix for this. It might also be a good idea to verify nothing else was unintentionally deleted or overwritten!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants