Skip to content

Remove text about the deprecated payment method "basic-card"#9212

Merged
jpmedley merged 16 commits intomdn:mainfrom
maxlgu:main
Sep 28, 2021
Merged

Remove text about the deprecated payment method "basic-card"#9212
jpmedley merged 16 commits intomdn:mainfrom
maxlgu:main

Conversation

@maxlgu
Copy link
Contributor

@maxlgu maxlgu commented Sep 23, 2021

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

Fixes #9211

What was wrong/why is this fix needed? (quick summary only)

W3C has deprecated the "basic-card" payment method[1], so MDN should remove the corresponding text as well.

[1] https://www.w3.org/TR/payment-method-basic-card/

Anything else that could help us review it

@maxlgu maxlgu requested a review from a team September 23, 2021 20:54
@maxlgu maxlgu requested review from a team as code owners September 23, 2021 20:54
@maxlgu maxlgu requested review from Rumyra and schalkneethling and removed request for a team September 23, 2021 20:54
@maxlgu
Copy link
Contributor Author

maxlgu commented Sep 23, 2021

@rsolomakhin

@maxlgu
Copy link
Contributor Author

maxlgu commented Sep 23, 2021

@rsolomakhin, @jpmedley , PTAL. Thanks!

rsolomakhin
rsolomakhin suggested changes Sep 23, 2021
View reviewed changes
Copy link

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should some page link to Google Pay, Samsung Pay, and Apple Pay tutorials or API reference?

@jpmedley jpmedley self-requested a review September 24, 2021 12:26
@jpmedley jpmedley self-assigned this Sep 24, 2021
jpmedley
jpmedley requested changes Sep 24, 2021
View reviewed changes
@maxlgu
Copy link
Contributor Author

maxlgu commented Sep 24, 2021

@rsolomakhin , Google Pay, Apple Pay have already lived in the payment_request_api/index.md page. I have just added Samsung Pay to the list.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Document/autoplayPolicy does not exist
  • sectioning:
    • 'WebRTC_and_media' is not a unique ID in this HTML (temporarily changed to WebRTC_and_media_2)

URL: /en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts
Title: Features restricted to secure contexts
on GitHub
Flaw count: 3

  • broken_links:
    • Anchor not lowercase
    • Can't resolve /en-US/docs/Web/HTML/Using_the_application_cache
    • Can't resolve /en-US/docs/Web/API/Detecting_device_orientation

URL: /en-US/docs/Web/API/PaymentResponse
Title: PaymentResponse
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentMethodData does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.AddressErrors

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/PaymentMethodChangeEvent
Title: PaymentMethodChangeEvent
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/PaymentMethodChangeEventInit does not exist

URL: /en-US/docs/Web/API/PaymentValidationErrors
Title: PaymentValidationErrors
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/PyamentValidationErrors/error does not exist
    • /en-US/docs/Web/API/PaymentValidationErrors/paymentMethod does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.PaymentValidationErrors

External URLs

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
on GitHub

URL: /en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts
Title: Features restricted to secure contexts
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse
Title: PaymentResponse
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/details
Title: PaymentResponse.details
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/onpaymentmethodchange
Title: PaymentRequest.onpaymentmethodchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/PaymentRequest
Title: PaymentRequest()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/canMakePayment
Title: PaymentRequest.canMakePayment()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress
Title: PaymentAddress
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/PaymentMethodChangeEvent
Title: PaymentMethodChangeEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentValidationErrors
Title: PaymentValidationErrors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Payment_Request_API
Title: Payment Request API
on GitHub

URL: /en-US/docs/Web/API/Payment_Request_API/Using_the_Payment_Request_API
Title: Using the Payment Request API
on GitHub

No new external URLs

(this comment was updated 2021-09-28 10:28:45.388988)

@maxlgu
Copy link
Contributor Author

maxlgu commented Sep 27, 2021

@jpmedley , do you know whether the reply by github-actions has anything that needs our attention? I am not familiar with submitting PR to MDN. Please let me know if any action from me is needed. Thanks!

This thread is waiting for @wbamberg 's reply. After that, an owner of this repo can merge the pull requests.

@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Sep 27, 2021
@maxlgu
Copy link
Contributor Author

maxlgu commented Sep 27, 2021

Addressed @jpmedley's concern on wiki history based on @wbamberg 's advice. So the thread is ready to review. PTAL. Thanks!

Specifically, I think the reviewer need to resolve 3 workflows awaiting approval and merge this pull request.

@jpmedley jpmedley merged commit b793e71 into mdn:main Sep 28, 2021
@queengooborg queengooborg mentioned this pull request Oct 9, 2021
Merged
@maxlgu maxlgu mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbamberg wbamberg wbamberg left review comments

@jpmedley jpmedley jpmedley approved these changes

@schalkneethling schalkneethling Awaiting requested review from schalkneethling

@Rumyra Rumyra Awaiting requested review from Rumyra

+1 more reviewer

@rsolomakhin rsolomakhin rsolomakhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpmedley jpmedley

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove text about the deprecated payment method "basic-card"

4 participants

@maxlgu @wbamberg @rsolomakhin @jpmedley