Intl segmenter updates by meyerweb · Pull Request #8402 · mdn/content

meyerweb · 2021-08-27T21:14:13Z

No description provided.

…tructor and supportedLocalesOf pages

* make spanish_segmenter more... modern? * add example and syntax to Segmenter#resolvedOptions * add example and syntax to Segmenter#segment * add information about segment data objects

github-actions · 2021-08-27T21:15:48Z

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter
Title: Intl.Segmenter
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segmenter

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/resolvedOptions
Title: Intl.Segmenter.prototype.resolvedOptions()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segmenter.resolvedOptions

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter
Title: Intl.Segmenter() constructor
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segmenter.constructor

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/segment
Title: Intl.Segmenter.prototype.segment()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segmenter.segment

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf
Title: Intl.Segmenter.supportedLocalesOf()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segmenter.supportedLocalesOf

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments
Title: Intl.Segments
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segments

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments/containing
Title: Intl.Segments.prototype.containing()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segments.containing

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments/@@iterator
Title: Intl.Segments.prototype[@@iterator]()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: javascript.builtins.Intl.Segments.@@iterator

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter
Title: Intl.Segmenter
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/resolvedOptions
Title: Intl.Segmenter.prototype.resolvedOptions()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter
Title: Intl.Segmenter() constructor
on GitHub

https://datatracker.ietf.org/doc/html/rfc4647 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/segment
Title: Intl.Segmenter.prototype.segment()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf
Title: Intl.Segmenter.supportedLocalesOf()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments
Title: Intl.Segments
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments/containing
Title: Intl.Segments.prototype.containing()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segments/@@iterator
Title: Intl.Segments.prototype[@@iterator]()
on GitHub

No new external URLs

(this comment was updated 2022-01-07 17:49:04.159442)

gibson042

The content here is good, but seems to diverge from conventions that exist elsewhere in https://github.com/mdn/content/tree/main/files/en-us/web/javascript/reference/global_objects/intl . I think those should be corrected before a more Segmenter-specific review.

files/en-us/web/javascript/reference/global_objects/intl/segmenter/constructor/index.md

files/en-us/web/javascript/reference/global_objects/intl/segmenter/index.md

files/en-us/web/javascript/reference/global_objects/intl/segmenter/segments/containing/index.md

files/en-us/web/javascript/reference/global_objects/intl/segmenter/segments/index.md

files/en-us/web/javascript/reference/global_objects/intl/segmenter/supportedlocalesof/index.md

…nter/constructor/index.md Co-authored-by: Richard Gibson <[email protected]>

Co-authored-by: Richard Gibson <[email protected]>

…nter/constructor/index.md Co-authored-by: Richard Gibson <[email protected]>

Co-authored-by: Richard Gibson <[email protected]>

…l-segmenter

…nter/segments/index.md Co-authored-by: Richard Gibson <[email protected]>

…nter/index.md Co-authored-by: Richard Gibson <[email protected]>

romulocintra · 2021-09-09T17:34:54Z

@meyerweb this PR closes tc39/ecma402-mdn#17 Thanks for the great work!!

meyerweb · 2021-09-10T16:01:31Z

@meyerweb this PR closes tc39/ecma402-mdn#17 Thanks for the great work!!

Glad to help! Except we’re not quite there: I still need to write the @@iterator page, and enhance the constructor page with a localeMatcher example.

Specifically, what I need is:

A compact (if possible) code example using .next(). Two or three examples would be even better!
A code example (or two) of different values of the option localeMatcher yielding different results for the locale when constructing an Intl.Segmenter.

If you have any sources for where I might find such things, I’d be most obliged!

romulocintra · 2021-09-28T14:52:39Z

Hi @meyerweb

A compact (if possible) code example using .next(). Two or three examples would be even better!

let segmenter = new Intl.Segmenter("fr", {granularity: "word"});
let input = "Moi?  N'est-ce pas.";
let segments = segmenter.segment(input);
let iterator = segments[Symbol.iterator]();

console.log(iterator.next().value); // logs {segment: 'Moi', index: 0, input: "Moi?  N'est-ce pas.", isWordLike: true}
console.log(iterator.next().value); // logs {segment: '?', index: 3, input: "Moi?  N'est-ce pas.", isWordLike: false}
console.log(iterator.next().value); // logs {segment: '  ', index: 4, input: "Moi?  N'est-ce pas.", isWordLike: false}
//...

Or

let segmenter = new Intl.Segmenter("fr", {granularity: "word"});
let input = "Moi?  N'est-ce pas.";
let segments = segmenter.segment(input);
let iterator = segments[Symbol.iterator]();

while (true) {
  let result = iterator.next()
  if (result.done) break;
  console.log(result.value)
}

/* Logs
{segment: 'Moi', index: 0, input: "Moi?  N'est-ce pas.", isWordLike: true}
{segment: '?', index: 3, input: "Moi?  N'est-ce pas.", isWordLike: false}
{segment: '  ', index: 4, input: "Moi?  N'est-ce pas.", isWordLike: false}
{segment: "N'est", index: 6, input: "Moi?  N'est-ce pas.", isWordLike: true}
{segment: '-', index: 11, input: "Moi?  N'est-ce pas.", isWordLike: false}
{segment: 'ce', index: 12, input: "Moi?  N'est-ce pas.", isWordLike: true}
{segment: ' ', index: 14, input: "Moi?  N'est-ce pas.", isWordLike: false}
{segment: 'pas', index: 15, input: "Moi?  N'est-ce pas.", isWordLike: true}
{segment: '.', index: 18, input: "Moi?  N'est-ce pas.", isWordLike: false}
*/

meyerweb · 2021-09-30T20:09:56Z

@romulocintra Please review the new page for the iterator and let me know if anything needs to be fixed. (Or submit your own edits — that works too.) Thanks!

romulocintra · 2021-10-01T08:24:40Z

@meyerweb LGTM, It's not a draft anymore, looks ready to review 👍🏿 great work! If something is missing the goal is to evolve along the time!!!

…nter/segment/index.md Co-authored-by: wbamberg <[email protected]>

…nter/segmenter/index.md Co-authored-by: wbamberg <[email protected]>

…nts/containing/index.md Co-authored-by: wbamberg <[email protected]>

…nts/@@iterator/index.md Co-authored-by: wbamberg <[email protected]>

…nter/supportedlocalesof/index.md Co-authored-by: wbamberg <[email protected]>

…nts/index.md Co-authored-by: wbamberg <[email protected]>

…nts/@@iterator/index.md Co-authored-by: wbamberg <[email protected]>

…enter

…nts/containing/index.md Co-authored-by: wbamberg <[email protected]>

SphinxKnight · 2022-01-07T06:05:37Z

@wbamberg thanks a lot for the swift review and catching a lot of things. I think there is only the localeMatcher issue remaining.

files/en-us/web/javascript/reference/global_objects/intl/segments/containing/index.md

wbamberg

There was one const that needed to be a let, that I just committed. Otherwise I'm very happy with this. Thanks @SphinxKnight for finishing this off, and @meyerweb and @romulocintra for all your work on it too.

I think perhaps we should not merge until mdn/browser-compat-data#14428 is merged, maybe we could nag someone to review that one.

SphinxKnight · 2022-01-09T15:09:58Z

and BCD PR is merged :)

teoli2003 · 2022-01-10T08:44:42Z

Merging this per the last two comments \o/

meyerweb and others added 3 commits August 6, 2021 16:17

Hydrated stub pages with metadata and structure; first drafts of cons…

ec21615

…tructor and supportedLocalesOf pages

Segmenter examples (#4)

3823c8c

* make spanish_segmenter more... modern? * add example and syntax to Segmenter#resolvedOptions * add example and syntax to Segmenter#segment * add information about segment data objects

Hit the 80-20 point on Intl.Segmenter

4cf1f15

gibson042 reviewed Aug 28, 2021

View reviewed changes

meyerweb and others added 12 commits August 30, 2021 15:12

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

267b5ce

…nter/constructor/index.md Co-authored-by: Richard Gibson <[email protected]>

Apply suggestions from code review

8847f7e

Co-authored-by: Richard Gibson <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

fe5a47d

…nter/constructor/index.md Co-authored-by: Richard Gibson <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

a4446b3

…nter/constructor/index.md Co-authored-by: Richard Gibson <[email protected]>

Fixed constructor structure

5180334

Fixed constructor structure

7cc850d

Apply suggestions from code review

cd6e244

Co-authored-by: Richard Gibson <[email protected]>

Merge branch 'intl-segmenter' of github.com:meyerweb/content into int…

491cf3d

…l-segmenter

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

4cfad67

…nter/segments/index.md Co-authored-by: Richard Gibson <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

4cff7f1

…nter/index.md Co-authored-by: Richard Gibson <[email protected]>

Fixed main index link reference

1a51a86

Fixed code block error

2ab4495

gibson042 mentioned this pull request Sep 2, 2021

Adding a UnicodeString type? tc39/proposal-is-usv-string#15

Closed

romulocintra mentioned this pull request Sep 9, 2021

Document Intl.Segmenter tc39/ecma402-mdn#17

Closed

teoli2003 added the Content:JS JavaScript docs label Sep 13, 2021

Wrote the @@iterator page

6485af7

meyerweb marked this pull request as ready for review October 1, 2021 13:59

meyerweb requested a review from a team as a code owner October 1, 2021 13:59

meyerweb requested review from sideshowbarker and removed request for a team October 1, 2021 13:59

SphinxKnight and others added 13 commits January 7, 2022 06:37

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

c5d67f4

…nter/segment/index.md Co-authored-by: wbamberg <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

9206b99

…nter/segmenter/index.md Co-authored-by: wbamberg <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

9148db9

…nts/containing/index.md Co-authored-by: wbamberg <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

a1eb2c6

…nts/@@iterator/index.md Co-authored-by: wbamberg <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

ee8a6b2

…nter/supportedlocalesof/index.md Co-authored-by: wbamberg <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

7e94452

…nts/index.md Co-authored-by: wbamberg <[email protected]>

Remove interactive example due to Fx missing impl.

f6a15fe

sort methods alphabetically

3e77e4d

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

ed7ef87

…nts/@@iterator/index.md Co-authored-by: wbamberg <[email protected]>

Favor const

7e21e2c

Merge remote-tracking branch 'meyerweb/intl-segmenter' into intl-segm…

0182004

…enter

improve example while condition

a958acb

Update files/en-us/web/javascript/reference/global_objects/intl/segme…

867c34d

…nts/containing/index.md Co-authored-by: wbamberg <[email protected]>

SphinxKnight requested a review from wbamberg January 7, 2022 06:03

DLify localeMatcher

4f6e9fd

wbamberg reviewed Jan 7, 2022

View reviewed changes

files/en-us/web/javascript/reference/global_objects/intl/segments/containing/index.md Outdated Show resolved Hide resolved

this one needs to be let

75bb590

wbamberg approved these changes Jan 7, 2022

View reviewed changes

teoli2003 merged commit c95e770 into mdn:main Jan 10, 2022

wbamberg pushed a commit to mdn/yari that referenced this pull request Jan 10, 2022

Add Intl.Segmenter in sidebar as part of mdn/content#8402 (#5132)

ca8ccc6

wbamberg mentioned this pull request Jan 11, 2022

Add glossary pages for code unit and code point #11897

Merged

SphinxKnight mentioned this pull request Mar 21, 2022

add interactive examples for intl/segmenter et al. #14124

Merged

3 tasks

SphinxKnight added a commit to SphinxKnight/content that referenced this pull request Mar 31, 2022

lonely follow-up of mdn#8402

1017b27

SphinxKnight mentioned this pull request Mar 31, 2022

Include Intl.Segmenter in JS Ref index, aka lonely follow-up of #8402 #14523

Merged

3 tasks

teoli2003 pushed a commit that referenced this pull request Mar 31, 2022

lonely follow-up of #8402 (#14523)

8efcb46

SphinxKnight mentioned this pull request May 5, 2022

Initial translation for Intl.Segmenter (incl. Segments) mdn/translated-content#5424

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023

Comments

Conversation

meyerweb commented Aug 27, 2021

Uh oh!

github-actions bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

gibson042 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romulocintra commented Sep 9, 2021

Uh oh!

meyerweb commented Sep 10, 2021

Uh oh!

romulocintra commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meyerweb commented Sep 30, 2021

Uh oh!

romulocintra commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SphinxKnight commented Jan 7, 2022

Uh oh!

Uh oh!

wbamberg left a comment

Choose a reason for hiding this comment

Uh oh!

SphinxKnight commented Jan 9, 2022

Uh oh!

teoli2003 commented Jan 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

github-actions bot commented Aug 27, 2021 •

edited

Loading

romulocintra commented Sep 28, 2021 •

edited

Loading

romulocintra commented Oct 1, 2021 •

edited

Loading