Conversation
This comment has been minimized.
This comment has been minimized.
teoli2003
suggested changes
Aug 24, 2021
Contributor
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
Two small fixes are needed. Else, this is really cool.
|
|
||
| <div class="overheadIndicator nonStandard nonStandardHeader"> | ||
| <p><strong>Caution:</strong><br> | ||
| <p><strong>Warning:</strong><br> |
Contributor
There was a problem hiding this comment.
Can you remove the <br>?
|
|
||
| <div class="warning"> | ||
| <p><strong>Warning: </strong>When implementing PushManager subscriptions, it is vitally important that you protect against CSRF/XSRF issues in your app. See the following articles for more information:</p> | ||
| <p><strong>Warning:</strong>When implementing PushManager subscriptions, it is vitally important that you protect against CSRF/XSRF issues in your app. See the following articles for more information:</p> |
Contributor
There was a problem hiding this comment.
Missing space after <\strong>
Collaborator
Author
|
I made those changes. Thanks again for all these reviews :). |
teoli2003
approved these changes
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #8180 (the last part, I hope).
It fixes up all warnings in Web/API so they are Markdown convertible. There weren't as many of these as the notes, so this is just one PR, but it's grouped by commits:
ImportanttoWarning<h4>-style to<strong>-style<p>; move colon inside<strong>(2 changes in this one commit I'm afraid)<strong>Warning</strong>prefix where it was missing entirely