Merged
Conversation
This comment has been minimized.
This comment has been minimized.
teoli2003
approved these changes
Aug 20, 2021
Contributor
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
I did three passes:
- A visual check of the preview output of each page.
- A check of the code of the multiline summary paragraphs.
- A check of the code of the summary paragraphs on one single line.
Contributor
|
Great! |
Collaborator
Author
|
Thank you for these tedious reviews @teoli2003 ! |
Collaborator
|
I think the ability to cope with tedium may be one of the core requirements for a tech writer :-0. |
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Aug 20, 2021
…remove-seosummary-nomatch * origin/remove-seosummary-nomatch: Fixed typo (mdn#8139) Fix link to fragment on same page (mdn#8128) Fix sectioning problem and remove redirect in Using the Painting API (mdn#8130) Fix sectioning flaw in WebGL Boilerplate #1 (mdn#8131) Remove {{draft}} from HTMLMediaElement.videoTracks (mdn#8129) Replace Intl/* with Intl.* (mdn#8136) chore(deps): bump @mdn/yari from 0.4.723 to 0.4.731 (mdn#8135) Convert Houdini docs to markdown Rename Houdini docs from .html to .md Move Web/Houdini to Web/Guide/Houdini Move files to CSS/CSS_Backgrounds_and_Borders (mdn#8121) Fix live sample box size in font-synthesis (mdn#8120) Remove all occurrences of dragexit event and ondragexit h… (mdn#8113) Clarify “How the Web works” section describing parse order (mdn#8108) Fix a link in Global_Objects/Object/propertyIsEnumerable (mdn#8119) Remove seoSummary, part 2 (mdn#8115) Remove seoSummary, part 1 (mdn#8114) index.html: typo (match </th> with opening <th>) (mdn#8112)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second of two PRs, after #8114, to remove all
seoSummaryclasses from the Web/API docs, in cases whereseoSummaryjust marks up the first (non-macro) paragraph in the page. In cases like this,seoSummaryhas no effect, and can therefore be safely removed.This is part of #8110.