Conversation
Contributor
jpmedley
requested changes
Aug 19, 2021
Collaborator
jpmedley
left a comment
jpmedley
left a comment
There was a problem hiding this comment.
Please see the comments I made on line 19 of the interface page. I don't believe your assessment of what this interface is is correct. I'd like to resolve this before I finish the review.
* Adding set methods * case * and back
jpmedley
requested changes
Sep 2, 2021
| --- | ||
| {{DefaultAPISidebar("DOM")}} | ||
|
|
||
| The **`entries`** method of the {{domxref("CustomStateSet")}} interface returns a new {{jsxref("Iterator")}} object, containing an array of `[value,value]` for each element in the `CustomStateSet`. |
Collaborator
There was a problem hiding this comment.
[value,value]? I don't understand.
Collaborator
Author
There was a problem hiding this comment.
Exactly what it says really, it's a set so there isn't a key, just the same as regular set entries https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/entries
Co-authored-by: Joe Medley <[email protected]>
jpmedley
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
CustomStateSetinterface in Markdown. As this is an addition toElementInternalsthis also adds the property page and link to that Interface in HTML.Reviewer @jpmedley