Conversation
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs |
oops — sorry, I was the reviewer for that one… And @mfuji09 was the author — so I reckon we both need to remember we shouldn’t be putting any more |
No worries. I don't think it's reasonable to expect everyone to remember all the details of Markdown conversion :) so it's inevitable there will be a bit of rework. And if this had landed as Markdown it would have been OK, but it's better to clean as much as we can. |
|
@wbamberg Good approach - allows figure captions to easily be recovered, if desired in future, and it carries through to the markdown. I do like figure captions but only if they are used everywhere in a doc set. I even like the idea "in theory" of mandating the alt text and generating figures from that. Practically speaking though, too many not present or worded poorly for this purpose. |
A read of the conversion report (#5193 (comment)) revealed that we recently had a PR that added
<figure>to the JS docs (https://github.com/mdn/content/pull/4762/files). While semantic markup is nice, we don't have a way to express this in GFM, so I'm removing it.I don't think these examples need a caption, but I added the text as alt text. I hope that's good enough.