Fold LinkStyle (a mixin) into its inheriting interfaces by queengooborg · Pull Request #5669 · mdn/content

queengooborg · 2021-06-04T09:28:55Z

This PR removes the pages for the LinkStyle mixin and remaps the references of its only member (sheet) to the individual interfaces. There is no page already in place for the member, unfortunately, so the link will remain a 404 for the time being.

Note: this is my first PR for the MDN content (though not my first content edit altogether), and especially my first attempt at a change like this. Please let me know if I missed anything!

Corresponding BCD PR: mdn/browser-compat-data#10724

teoli2003

There is a mention of LinkStyle in https://developer.mozilla.org/en-US/docs/Web/API/SVGStyleElement . I think we should add the sheet method here too (like in HTMLStyleElement, HTMLLinkElement, ProcessingInstruction).

I've not double checked, but I think doing rg LinkStyle * in api/ to check that every mentions of LinkStyle have been dealt with may be useful. (rg is a recursive version of grep).

Very happy to see LinkStyle going away.

files/en-us/_redirects.txt

files/en-us/web/api/htmllinkelement/index.html

github-actions · 2021-06-04T14:38:16Z

Preview URLs

Flaws

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub
Flaw count: 19

macros:
- /en-US/docs/Web/API/SVGColor does not exist
- /en-US/docs/Web/API/SVGICCColor does not exist
- /en-US/docs/Web/API/SVGElementInstance does not exist
- /en-US/docs/Web/API/SVGElementInstanceList does not exist
- /en-US/docs/Web/CSS/vector-effect does not exist
- and 14 more flaws omitted

URL: /en-US/docs/Web/API/SVGStyleElement
Title: SVGStyleElement
on GitHub
Flaw count: 3

macros:
- /en-US/docs/Web/API/SVGStyleElement/type does not exist
- /en-US/docs/Web/API/SVGStyleElement/media does not exist
- /en-US/docs/Web/API/SVGStyleElement/title does not exist

URL: /en-US/docs/Web/API/CSSStyleSheet
Title: CSSStyleSheet
on GitHub
Flaw count: 4

macros:
- /en-US/docs/Web/API/HTMLLinkElement/sheet does not exist
- /en-US/docs/Web/API/HTMLStyleElement/sheet does not exist
- /en-US/docs/Web/API/SVGStyleElement/sheet does not exist
- /en-US/docs/Web/API/ProcessingInstruction/sheet does not exist

URL: /en-US/docs/Web/API/CSS_Object_Model
Title: CSS Object Model (CSSOM)
on GitHub
Flaw count: 7

macros:
- /en-US/docs/Web/API/CSSCharsetRule does not exist
- /en-US/docs/Web/API/CSSFontFeatureValuesMap does not exist
- /en-US/docs/Web/API/CSSFontFeatureValuesRule does not exist
- /en-US/docs/Web/API/CSSMarginRule does not exist
- /en-US/docs/Web/API/CSSVariablesMap does not exist
- and 2 more flaws omitted

URL: /en-US/docs/Web/API/HTMLStyleElement
Title: HTMLStyleElement
on GitHub
Flaw count: 7

macros:
- /en-US/docs/Web/API/HTMLStyleElement/disabled does not exist
- wrong xref macro used (consider changing which macro you use)
- /en-US/docs/Web/API/HTMLStyleElement/sheet does not exist
- wrong xref macro used (consider changing which macro you use)
broken_links:
- Can't resolve /en-US/docs/DOM/Using_dynamic_styling_information
bad_bcd_links:
- no explanation!
- no explanation!

URL: /en-US/docs/Web/API/HTMLLinkElement
Title: HTMLLinkElement
on GitHub
Flaw count: 14

macros:
- /en-US/docs/Web/API/HTMLLinkElement/crossOrigin does not exist
- /en-US/docs/Web/API/HTMLLinkElement/disabled does not exist
- /en-US/docs/Web/API/HTMLLinkElement/href does not exist
- /en-US/docs/Web/API/HTMLLinkElement/hreflang does not exist
- /en-US/docs/Web/API/HTMLLinkElement/media does not exist
- and 7 more flaws omitted
bad_bcd_links:
- no explanation!
- no explanation!

URL: /en-US/docs/Mozilla/Firefox/Releases/46
Title: Firefox 46 for developers
on GitHub
Flaw count: 7

macros:
- /en-US/docs/Web/CSS/@font/font-display does not exist
- /en-US/docs/Web/CSS/@font does not exist
- /en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet/clear does not exist
- /en-US/docs/Web/JavaScript/Reference/Operators/Array_comprehensions does not exist
- /en-US/docs/Web/JavaScript/Reference/Operators/Generator_comprehensions does not exist
- and 2 more flaws omitted

External URLs

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGStyleElement
Title: SVGStyleElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSStyleSheet
Title: CSSStyleSheet
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSS_Object_Model
Title: CSS Object Model (CSSOM)
on GitHub

URL: /en-US/docs/Web/API/HTMLStyleElement
Title: HTMLStyleElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLLinkElement
Title: HTMLLinkElement
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/46
Title: Firefox 46 for developers
on GitHub

No new external URLs

(this comment was updated 2021-06-08 13:22:38.053554)

Rumyra

Hi @vinyldarkscratch 👋 this looks awesome 😎

Seems tests are failing on redirect because the sheet property page doesn't exist. Basically it seems it just never got written... I think possibly for the moment we just redirect any Link/sheet urls to Web/API/HTMLLinkElement

I've added a suggestion, but happy to have a better one :)

files/en-us/_redirects.txt

foolip · 2021-06-04T21:03:09Z

files/en-us/mozilla/firefox/releases/46/index.html


 <ul>
- <li>In SVG, the {{domxref("SVGStyleElement")}} interface now implements the {{domxref("LinkStyle")}} mixin ){{bug(1239128)}}.</li>
+ <li>In SVG, the {{domxref("SVGStyleElement")}} interface now implements the {{domxref("SVGStyleElement.sheet")}} member ){{bug(1239128)}}.</li>


In release notes, let's not change any wording, but just remove the domxref and use just <code> instead.

foolip · 2021-06-04T21:05:51Z

files/en-us/web/api/htmllinkelement/index.html

   <td>{{SpecName('DOM2 HTML', 'html.html#ID-35143001', 'HTMLLinkElement')}}</td>
   <td>{{Spec2('DOM2 HTML')}}</td>
-   <td>Added a second inheritence, the {{domxref("LinkStyle")}} interface.</td>
+   <td>Added a second inheritence, the LinkStyle mixin, exposing the {{domxref("HTMLLinkElement.sheet")}} member.</td>


In spec tables I would also leave the text unchanged, just replace the domxref.

foolip

Looks good apart from one small nit.

files/en-us/web/api/cssstylesheet/index.html

foolip · 2021-06-08T07:10:28Z

@Rumyra might you be able to review this? If you agree with my suggestion, just applying it an merging should be OK.

Co-authored-by: Philip Jägenstedt <[email protected]>

Rumyra · 2021-06-08T13:22:45Z

Approved @foolip - I'm unsure of the status of the two unresolved conversations above - are we ok to merge? Happy to do so :)

foolip · 2021-06-08T13:29:10Z

@Rumyra those issues have been resolved. I'm not sure why there's no "resolve" button, but they're outdated at any rate.

Rumyra · 2021-06-09T13:27:47Z

@foolip weirdly I do have a resolve button hence the query 🤷🏻‍♀️ anyways thank you 🙏 all merged ☺️

Fold LinkStyle (a mixin) into its inheriting interfaces

d0b614c

queengooborg requested review from a team as code owners June 4, 2021 09:28

queengooborg requested review from Rumyra and removed request for a team June 4, 2021 09:28

queengooborg mentioned this pull request Jun 4, 2021

Demix LinkStyle mixin mdn/browser-compat-data#10724

Merged

teoli2003 reviewed Jun 4, 2021

View reviewed changes

files/en-us/_redirects.txt Show resolved Hide resolved

queengooborg added 2 commits June 4, 2021 03:06

Un-remove redirect and correct

58d7cd3

Remove ALL mentions of LinkStyle

78336d8

queengooborg requested a review from a team June 4, 2021 10:17

queengooborg commented Jun 4, 2021

View reviewed changes

files/en-us/web/api/htmllinkelement/index.html Outdated Show resolved Hide resolved

Rumyra requested changes Jun 4, 2021

View reviewed changes

files/en-us/_redirects.txt Outdated Show resolved Hide resolved

Redirect sheet to just HTMLLinkElement for now

fa6aa64

foolip suggested changes Jun 4, 2021

View reviewed changes

Revert wording; use code block instead

85c9c49

foolip approved these changes Jun 8, 2021

View reviewed changes

files/en-us/web/api/cssstylesheet/index.html Outdated Show resolved Hide resolved

Update files/en-us/web/api/cssstylesheet/index.html

e19f3ac

Co-authored-by: Philip Jägenstedt <[email protected]>

Rumyra approved these changes Jun 8, 2021

View reviewed changes

Rumyra merged commit 0931f33 into mdn:main Jun 9, 2021

queengooborg deleted the demix-LinkStyle branch June 9, 2021 20:47

github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022

Conversation

queengooborg commented Jun 4, 2021

Uh oh!

teoli2003 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

Rumyra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

foolip Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

teoli2003 Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

foolip Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

foolip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

foolip commented Jun 8, 2021

Uh oh!

Rumyra commented Jun 8, 2021

Uh oh!

foolip commented Jun 8, 2021

Uh oh!

Rumyra commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

teoli2003 left a comment •

edited

Loading

github-actions bot commented Jun 4, 2021 •

edited

Loading