Conversation
This comment has been minimized.
This comment has been minimized.
chrisdavidmills
left a comment
There was a problem hiding this comment.
Yup yup! Nice work.
|
oop, little conflict to fix. |
No, not just you. I thought it was slightly awkward when I wrote it, but it was a solution (to my problem of not wanting to count more things than I have fingers) that could be achieved through an uncomplicated regular expression. The right way to do this is probably to make a section for this, like the permitted property lists we came up for the CSS recipe:
Or for cases where all elements are supported:
|
Yes, I agree (and had the same thought, after commenting of course). |
|
I could do that with this PR, unless you think we ought to put it up for discussion more widely first. |
|
@Rumyra , @Elchi3 , are you +1 on Daniel making the change described in #5148 (comment) ? Are there other people we should ask here? |
|
Sounds good to me! (I will say here that I'm not a big fan of attribute reference pages. I think if I would write SVG docs from scratch, attribute pages would sit inline or under their element page. Yes, this might mean some duplication, but at least I could then document the attribute in context of its element. I could be convinced if readers would search for attributes on their own specifically, but right now I'm not. I think readers will want to use attributes in the context of an element, so 🤷 ) |
|
Yeh looks good to me :) |
|
@ddbeck This status of this PR seems to be that it’s waiting for the change described in #5148 (comment) to be made, right? |
|
@sideshowbarker Yes, that's correct and this PR slipped my mind. I'll try to finish this today (but definitely by the end of my day tomorrow). |
|
OK, I kinda regret that I spent as much time on this as I have today, but I've now turned these very long sentences into actual lists or a paragraph saying, "You can use this attribute with any SVG element." I tried to make this as regular as I could, across all of the SVG attribute pages. As you can see, it's a huge diff. I'm sorry. There is something I haven't done: created a section for "Applicable elements", as previously discussed. That's kinda hard to do in a quick-and-dirty way, particularly because it's underspecified. I don't know where in the outline the section should go and I don't think the page type is sufficiently well-defined trust that I could insert the section in the right spot. Honestly, I don't think it's a good use of my time to sort this out page-by-page, so I propose leaving it at this. Like @Elchi3 says, these pages might not be that interesting to readers anyway. If y'all think this is good enough, let's merge this (barring any immediate brokenness to deal with) and move on. |
wbamberg
left a comment
There was a problem hiding this comment.
Thanks Daniel, for your work on this. I found a few formatting typos.
While most of these pages have this bit at the start, before the example, a few have placed it later. I found:
https://pr5148.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Attribute/mask
https://pr5148.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Attribute/viewBox
https://pr5148.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Attribute/pointer-events
https://pr5148.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Attribute/transform
https://pr5148.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Attribute/color-profile
It's a little weird how these pages plunge right from this into the example, but when we remove all the div id= from the live samples we will want to add "Example" H2 headings, and that should help these pages communicate their organization better.
Co-authored-by: wbamberg <[email protected]>
I think that those 5 cases should follow the pattern of the other pages, and include this "You can use this attribute" bit at the start, immediately after the introductory paragraph. Sorry to be unclear, this bit of my comment:
...was more of a general comment about all these pages, and not a thing I expect you to do anything about in this PR. |
Thank you for the clarification. Done! ✅ |

Never count attributes again! This is a follow up to #5147. It changes all the remaining cases of:
to