Remove unimplemented SVG color-profile and solidcolor by ddbeck · Pull Request #5147 · mdn/content

ddbeck · 2021-05-20T12:05:22Z

What was wrong/why is this fix needed? (quick summary only)

Remove some pages and cross references to correspond to feature removals in BCD. See mdn/browser-compat-data#10515.

MDN URL of the main page changed

Chiefly but not exclusively:

https://developer.mozilla.org/docs/Web/API/SVGColorProfileElement
https://developer.mozilla.org/docs/Web/API/SVGSolidcolorElement
https://developer.mozilla.org/docs/Web/SVG/Element/color-profile
https://developer.mozilla.org/docs/Web/SVG/Element/solidcolor

Issue number (if there is an associated issue)

mdn/browser-compat-data#10515

Anything else that could help us review it

cc: @sideshowbarker

Content changes to correspond to BCD: mdn/browser-compat-data#10515

github-actions · 2021-05-20T12:07:42Z

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub
Flaw count: 22

macros:
- /en-US/docs/Web/API/SVGLocatable does not exist
- /en-US/docs/Web/API/SVGTransformable does not exist
- /en-US/docs/Web/API/SVGColor does not exist
- /en-US/docs/Web/API/SVGICCColor does not exist
- /en-US/docs/Web/API/SVGElementInstance does not exist
- and 17 more flaws omitted

URL: /en-US/docs/Web/SVG/Attribute/requiredFeatures
Title: requiredFeatures
on GitHub
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/DOM/DOMImplementation.hasFeature
- Can't resolve /files/3286/requiredFeatures.svg

URL: /en-US/docs/Web/SVG/Attribute/xlink:arcrole
Title: xlink:arcrole
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Glossary/IRI does not exist

URL: /en-US/docs/Web/SVG/Content_type
Title: Content type
on GitHub
Flaw count: 7

macros:
- /en-US/docs/Web/API/SVGAnimatedAngle_objects does not exist
- /en-US/docs/Web/API/SVGColor does not exist
- /en-US/docs/Web/API/SVGPaint does not exist
broken_links:
- No need for the pathname in anchor links if it's the same page
- No need for the pathname in anchor links if it's the same page
- Is currently http:// but can become https://
- No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub
Flaw count: 60

macros:
- /en-US/docs/Web/API/DOMConfiguration does not exist
- /en-US/docs/Web/API/DOMErrorHandler does not exist
- /en-US/docs/Web/API/DOMImplementationList does not exist
- /en-US/docs/Web/API/DOMImplementationRegistry does not exist
- /en-US/docs/Web/API/DOMImplementationSource does not exist
- and 55 more flaws omitted

External URLs

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub

URL: /en-US/docs/Web/SVG/Element
Title: SVG element reference
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Attribute/xlink:title
Title: xlink:title
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Attribute/name
Title: name
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Attribute/requiredFeatures
Title: requiredFeatures
on GitHub

URL: /en-US/docs/Web/SVG/Attribute/xlink:arcrole
Title: xlink:arcrole
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Attribute/xlink:type
Title: xlink:type
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Attribute/xlink:href
Title: xlink:href
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Content_type
Title: Content type
on GitHub

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub

https://dom.spec.whatwg.org/ (1 time)

(this comment was updated 2021-05-20 12:49:49.966249)

chrisdavidmills

Nice work @ddbeck . A few bits I think need looking at, but nothing much.

Also, does @sideshowbarker want to look at this one?

files/en-us/web/svg/attribute/xlink_colon_arcrole/index.html

files/en-us/web/svg/attribute/xlink_colon_href/index.html

files/en-us/web/svg/attribute/xlink_colon_title/index.html

chrisdavidmills · 2021-05-20T12:21:12Z

files/en-us/web/svg/attribute/xlink_colon_type/index.html

 <p>The <strong><code>xlink:type</code></strong> attribute identifies the type of {{Glossary("XLink")}} being used. In SVG, only simple links are available.</p>

-<p>Twenty two elements are using this attribute: {{SVGElement("a")}}, {{SVGElement("altGlyph")}}, {{SVGElement("animate")}}, {{SVGElement("animateColor")}}, {{SVGElement("animateMotion")}}, {{SVGElement("animateTransform")}}, {{SVGElement("color-profile")}}, {{SVGElement("cursor")}}, {{SVGElement("feImage")}}, {{SVGElement("filter")}}, {{SVGElement("font-face-uri")}}, {{SVGElement("glyphRef")}}, {{SVGElement("image")}}, {{SVGElement("linearGradient")}}, {{SVGElement("mpath")}}, {{SVGElement("pattern")}}, {{SVGElement("radialGradient")}}, {{SVGElement("script")}}, {{SVGElement("set")}}, {{SVGElement("textPath")}}, {{SVGElement("tref")}}, and {{SVGElement("use")}}</p>
+<p>Twenty two elements are using this attribute: {{SVGElement("a")}}, {{SVGElement("altGlyph")}}, {{SVGElement("animate")}}, {{SVGElement("animateColor")}}, {{SVGElement("animateMotion")}}, {{SVGElement("animateTransform")}}, {{SVGElement("cursor")}}, {{SVGElement("feImage")}}, {{SVGElement("filter")}}, {{SVGElement("font-face-uri")}}, {{SVGElement("glyphRef")}}, {{SVGElement("image")}}, {{SVGElement("linearGradient")}}, {{SVGElement("mpath")}}, {{SVGElement("pattern")}}, {{SVGElement("radialGradient")}}, {{SVGElement("script")}}, {{SVGElement("set")}}, {{SVGElement("textPath")}}, {{SVGElement("tref")}}, and {{SVGElement("use")}}</p>


"Twenty-one"

This one got missed; update it to be consistent with the others, and I think we're good to go!

Fixed! Plus #5148

ddbeck · 2021-05-20T12:30:15Z

@chrisdavidmills Nice catch. Is the count particularly interesting? What do you think of the change I've just pushed?

chrisdavidmills

Just one comment. I think your approach here is fine, as long as all instances are consistent. I don't think the number is important or needed.

chrisdavidmills · 2021-05-20T12:32:59Z

files/en-us/web/svg/attribute/xlink_colon_type/index.html

 <p>The <strong><code>xlink:type</code></strong> attribute identifies the type of {{Glossary("XLink")}} being used. In SVG, only simple links are available.</p>

-<p>Twenty two elements are using this attribute: {{SVGElement("a")}}, {{SVGElement("altGlyph")}}, {{SVGElement("animate")}}, {{SVGElement("animateColor")}}, {{SVGElement("animateMotion")}}, {{SVGElement("animateTransform")}}, {{SVGElement("color-profile")}}, {{SVGElement("cursor")}}, {{SVGElement("feImage")}}, {{SVGElement("filter")}}, {{SVGElement("font-face-uri")}}, {{SVGElement("glyphRef")}}, {{SVGElement("image")}}, {{SVGElement("linearGradient")}}, {{SVGElement("mpath")}}, {{SVGElement("pattern")}}, {{SVGElement("radialGradient")}}, {{SVGElement("script")}}, {{SVGElement("set")}}, {{SVGElement("textPath")}}, {{SVGElement("tref")}}, and {{SVGElement("use")}}</p>
+<p>Twenty two elements are using this attribute: {{SVGElement("a")}}, {{SVGElement("altGlyph")}}, {{SVGElement("animate")}}, {{SVGElement("animateColor")}}, {{SVGElement("animateMotion")}}, {{SVGElement("animateTransform")}}, {{SVGElement("cursor")}}, {{SVGElement("feImage")}}, {{SVGElement("filter")}}, {{SVGElement("font-face-uri")}}, {{SVGElement("glyphRef")}}, {{SVGElement("image")}}, {{SVGElement("linearGradient")}}, {{SVGElement("mpath")}}, {{SVGElement("pattern")}}, {{SVGElement("radialGradient")}}, {{SVGElement("script")}}, {{SVGElement("set")}}, {{SVGElement("textPath")}}, {{SVGElement("tref")}}, and {{SVGElement("use")}}</p>


This one got missed; update it to be consistent with the others, and I think we're good to go!

chrisdavidmills

Perfect; nice one @ddbeck

sideshowbarker · 2021-05-21T04:56:24Z

Also, does @sideshowbarker want to look at this one?

I post-commit reviewed it, and it all looks great to me

Remove unimplemented SVG color-profile and solidcolor

27b7ddf

Content changes to correspond to BCD: mdn/browser-compat-data#10515

ddbeck requested a review from a team as a code owner May 20, 2021 12:05

ddbeck requested a review from a team May 20, 2021 12:05

ddbeck requested a review from a team as a code owner May 20, 2021 12:05

ddbeck requested review from chrisdavidmills and removed request for a team May 20, 2021 12:05

ddbeck mentioned this pull request May 20, 2021

Remove unimplemented SVG color-profile & solidcolor elements mdn/browser-compat-data#10515

Merged

chrisdavidmills requested changes May 20, 2021

View reviewed changes

Fix attribute usage miscounts

fac344f

chrisdavidmills requested changes May 20, 2021

View reviewed changes

Make xlink:type consistent

24b083d

ddbeck mentioned this pull request May 20, 2021

Drop SVG attribute counts #5148

Merged

chrisdavidmills approved these changes May 20, 2021

View reviewed changes

chrisdavidmills merged commit 6a1dddd into mdn:main May 20, 2021

ddbeck deleted the bcd-10515-removals branch May 20, 2021 13:20

github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unimplemented SVG color-profile and solidcolor#5147

Remove unimplemented SVG color-profile and solidcolor#5147
chrisdavidmills merged 3 commits intomdn:mainfrom
ddbeck:bcd-10515-removals

ddbeck commented May 20, 2021

Uh oh!

github-actions bot commented May 20, 2021 •

edited

Loading

Uh oh!

chrisdavidmills left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisdavidmills May 20, 2021

Uh oh!

chrisdavidmills May 20, 2021 •

edited

Loading

Uh oh!

ddbeck May 20, 2021

Uh oh!

ddbeck commented May 20, 2021

Uh oh!

chrisdavidmills left a comment

Uh oh!

chrisdavidmills May 20, 2021 •

edited

Loading

Uh oh!

chrisdavidmills left a comment

Uh oh!

sideshowbarker commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ddbeck commented May 20, 2021

Uh oh!

github-actions bot commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

chrisdavidmills left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisdavidmills May 20, 2021

Choose a reason for hiding this comment

Uh oh!

chrisdavidmills May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ddbeck May 20, 2021

Choose a reason for hiding this comment

Uh oh!

ddbeck commented May 20, 2021

Uh oh!

chrisdavidmills left a comment

Choose a reason for hiding this comment

Uh oh!

chrisdavidmills May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisdavidmills left a comment

Choose a reason for hiding this comment

Uh oh!

sideshowbarker commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented May 20, 2021 •

edited

Loading

chrisdavidmills May 20, 2021 •

edited

Loading

chrisdavidmills May 20, 2021 •

edited

Loading