Skip to content

Comments

Remove never-implemented CSS at-rule features#5122

Merged
chrisdavidmills merged 4 commits intomdn:mainfrom
ddbeck:bcd-6944-removals
May 20, 2021
Merged

Remove never-implemented CSS at-rule features#5122
chrisdavidmills merged 4 commits intomdn:mainfrom
ddbeck:bcd-6944-removals

Conversation

@ddbeck
Copy link
Contributor

@ddbeck ddbeck commented May 19, 2021

What was wrong/why is this fix needed? (quick summary only)

In mdn/browser-compat-data#6944, we're dropping some features which are all-false. In addition to being unsupported, these features don't show any sign of being implemented (i.e., a search of Firefox, Chrome, and WebKit bugs doesn't turn up any evidence of implementation—with one exception, below).

MDN URL of the main page changed

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-transparency
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/scan
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/bleed
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/marks

Issue number (if there is an associated issue)

mdn/browser-compat-data#6944

Anything else that could help us review it

The scan media query is exceptional: it may be partially implemented in Chrome, but it doesn't do anything (for obvious reasons, I couldn't confirm this via testing). It seems to have been retained as a convenience to specification authors. See d9c73be for details.

ddbeck added 4 commits May 19, 2021 17:00
This is sorta-kinda implemented in a way that's meaningless. It appears
to have preserved as a convenience to spec authors:

w3c/csswg-drafts#594
w3c/csswg-drafts#1778
w3c/csswg-drafts@2c28928
@ddbeck ddbeck requested review from a team as code owners May 19, 2021 17:22
@ddbeck ddbeck requested review from chrisdavidmills and removed request for a team May 19, 2021 17:22
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Accessibility/Seizure_disorders
Title: Web accessibility for seizures and physical reactions
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/prefers-reduced-motion does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/CSSKeyframe/keyText

URL: /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
Title: Using media queries
on GitHub
Flaw count: 6

  • broken_links:
    • Is currently http:// but can become https://
    • Anchor not lowercase
    • Anchor not lowercase
    • Is currently http:// but can become https://
    • Anchor not lowercase
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/@page
Title: @page
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/:recto does not exist
    • /en-US/docs/Web/CSS/:verso does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/Accessibility/Seizure_disorders
Title: Web accessibility for seizures and physical reactions
on GitHub


URL: /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
Title: Using media queries
on GitHub


URL: /en-US/docs/Web/CSS/@page
Title: @page
on GitHub


URL: /en-US/docs/Web/CSS/@page/size
Title: size
on GitHub

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me; thanks @ddbeck !

@chrisdavidmills chrisdavidmills merged commit 48597b6 into mdn:main May 20, 2021
@ddbeck ddbeck deleted the bcd-6944-removals branch May 20, 2021 12:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants