Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs by sideshowbarker · Pull Request #4772 · mdn/content

sideshowbarker · 2021-05-06T22:43:32Z

whatwg/html@32a7a20 completely removed the URLUtilsReadOnly interface and moved/inlined/hoisted its members up into the WorkerLocation interface. So this change deletes all the URLUtilsReadOnly docs, and redirects them to the WorkerLocation docs.

Related BCD change: mdn/browser-compat-data#10347

github-actions · 2021-05-06T22:45:51Z

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WorkerLocation/pathname
Title: WorkerLocation.pathname
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.pathname

URL: /en-US/docs/Web/API/WorkerLocation/hash
Title: WorkerLocation.hash
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.hash

URL: /en-US/docs/Web/API/WorkerLocation/search
Title: WorkerLocation.search
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.search

URL: /en-US/docs/Web/API/WorkerLocation/host
Title: WorkerLocation.host
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.host

URL: /en-US/docs/Web/API/WorkerLocation/port
Title: WorkerLocation.port
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.port

URL: /en-US/docs/Web/API/WorkerLocation/protocol
Title: WorkerLocation.protocol
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.protocol

URL: /en-US/docs/Web/API/WorkerLocation/origin
Title: WorkerLocation.origin
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.origin

URL: /en-US/docs/Web/API/WorkerLocation/hostname
Title: WorkerLocation.hostname
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.hostname

URL: /en-US/docs/Web/API/WorkerLocation/toString
Title: WorkerLocation.toString()
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.toString

URL: /en-US/docs/Web/API/WorkerLocation/href
Title: WorkerLocation.href
on GitHub
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.WorkerLocation.href

URL: /en-US/docs/Web/API/URL_API
Title: URL API
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url()

External URLs

URL: /en-US/docs/Web/API/WorkerLocation
Title: WorkerLocation
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/pathname
Title: WorkerLocation.pathname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/hash
Title: WorkerLocation.hash
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/search
Title: WorkerLocation.search
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/host
Title: WorkerLocation.host
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/port
Title: WorkerLocation.port
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/protocol
Title: WorkerLocation.protocol
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/origin
Title: WorkerLocation.origin
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/hostname
Title: WorkerLocation.hostname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/toString
Title: WorkerLocation.toString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/href
Title: WorkerLocation.href
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URL_API
Title: URL API
on GitHub

(this comment was updated 2021-05-07 05:04:36.072317)

wbamberg

This looks fine, although I had a question about one sentence that didn't seem very useful any more.

But it looks like all the redirects work, and the redirect entries match the removed files.

files/en-us/web/api/url_api/index.html

whatwg/html@32a7a20 completely removed the URLUtilsReadOnly interface and moved/inlined/hoisted its members up into the WorkerLocation interface. So this change deletes URLUtilsReadOnly, and moves its members to WorkerLocation. This change also adds spec URLs to the WorkerLocation data. Related MDN change: mdn/content#4772

whatwg/html@32a7a20 completely removed the URLUtilsReadOnly interface and moved/inlined/hoisted its members up into the WorkerLocation interface. So this change deletes all the URLUtilsReadOnly docs, and redirects them to the WorkerLocation docs. Related BCD change: mdn/browser-compat-data#10347

chrisdavidmills

Looks like @sideshowbarker 's latest changes satisfied @wbamberg 's query, so I think I'll go ahead and merge this. Thanks Mike!

* Delete URLUtilsReadOnly, move members to WorkerLocation whatwg/html@32a7a20 completely removed the URLUtilsReadOnly interface and moved/inlined/hoisted its members up into the WorkerLocation interface. So this change deletes URLUtilsReadOnly, and moves its members to WorkerLocation. This change also adds spec URLs to the WorkerLocation data. Related MDN change: mdn/content#4772 * Apply suggestions from code review Co-authored-by: Florian Scholz <[email protected]> Co-authored-by: Florian Scholz <[email protected]>

sideshowbarker requested review from a team as code owners May 6, 2021 22:43

sideshowbarker requested review from chrisdavidmills and removed request for a team May 6, 2021 22:43

sideshowbarker marked this pull request as draft May 7, 2021 01:29

wbamberg reviewed May 7, 2021

View reviewed changes

files/en-us/web/api/url_api/index.html Outdated Show resolved Hide resolved

sideshowbarker marked this pull request as ready for review May 7, 2021 04:28

sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from 7b34220 to 646b988 Compare May 7, 2021 04:31

sideshowbarker changed the title ~~Delete URLUtilsReadOnly docs, redirect to URL docs~~ Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs May 7, 2021

sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from 646b988 to fe68d32 Compare May 7, 2021 04:34

sideshowbarker mentioned this pull request May 7, 2021

Delete URLUtilsReadOnly, move members to WorkerLocation mdn/browser-compat-data#10347

Merged

sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from fe68d32 to 5c788dd Compare May 7, 2021 05:02

sideshowbarker requested a review from wbamberg May 7, 2021 05:14

sideshowbarker mentioned this pull request May 7, 2021

Add URL* object spec URLs mdn/browser-compat-data#10339

Merged

chrisdavidmills approved these changes May 7, 2021

View reviewed changes

chrisdavidmills merged commit 5e27ba0 into main May 7, 2021

chrisdavidmills deleted the sideshowbarker/URLUtilsReadOnly-move branch May 7, 2021 07:15

github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs #4772

Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs #4772
chrisdavidmills merged 1 commit intomainfrom
sideshowbarker/URLUtilsReadOnly-move

sideshowbarker commented May 6, 2021 •

edited

Loading

Uh oh!

github-actions bot commented May 6, 2021 •

edited

Loading

Uh oh!

wbamberg left a comment

Uh oh!

Uh oh!

chrisdavidmills left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

sideshowbarker commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

wbamberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisdavidmills left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sideshowbarker commented May 6, 2021 •

edited

Loading

github-actions bot commented May 6, 2021 •

edited

Loading