New pages: *-rule-visibility-items#44616
Conversation
|
Preview URLs (4 pages)
Flaws (39) Found an unexpected or unresolvable flaw? Please report it here. URL:
URL:
URL:
URL:
(comment last updated: 2026-07-03 08:31:34) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
@estelle, looking really good. Quite a few comments, but they are mostly language nitpicks that are repeated across all three pages, so not actually that much to do here.
| sidebar: cssref | ||
| --- | ||
|
|
||
| The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether a rule segment is painted in portions of gaps adjacent to empty areas, setting both the {{cssxref("column-rule-visibility-items")}} and {{cssxref("row-rule-visibility-items")}} to the same value. |
There was a problem hiding this comment.
| The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether a rule segment is painted in portions of gaps adjacent to empty areas, setting both the {{cssxref("column-rule-visibility-items")}} and {{cssxref("row-rule-visibility-items")}} to the same value. | |
| The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether row-rule and column-rule segments are painted in gaps adjacent to empty areas. |
I think this can be cut down, given that the removed info is covered immediately below in the constituent properties section, and in the description.
There was a problem hiding this comment.
went with:
The
rule-visibility-itemsCSS shorthand property defines whether rule segments are painted in both row and column gaps adjacent to empty areas.
|
|
||
| #### CSS | ||
|
|
||
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`. |
There was a problem hiding this comment.
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`. | |
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} properties to `repeat(4, 1fr)`, and move the last item to the bottom-right grid area using the {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` rules. We set the column rules to `dashed` and the row rules to `solid`. |
|
|
||
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`. | ||
|
|
||
| Finally, we set `rule-visibility-items` to `between`, so only if both grid area adjacent to a column rule segment contains a grid item with the column rule be painted. |
There was a problem hiding this comment.
| Finally, we set `rule-visibility-items` to `between`, so only if both grid area adjacent to a column rule segment contains a grid item with the column rule be painted. | |
| Finally, we set `rule-visibility-items` to `between`, so that row- and column-rules are painted only if both grid areas adjacent to them contain a grid item. |
This sentence was a bit mixed up; I think I've captured the meaning correctly, but you should check it carefully.
|
|
||
| #### Result | ||
|
|
||
| {{EmbedLiveSample("Basic", "", "230")}} |
There was a problem hiding this comment.
Nice little demo.
My one nitpick is that the list markers overlap the rules, which looks a bit scruffy. Maybe add some margin-left to the <li>s to stop this from happening?
| @@ -0,0 +1,176 @@ | |||
| --- | |||
There was a problem hiding this comment.
One thing I've noticed is that column-rule-visibility-items is nested underneath column-* in the sidebar, but row-rule-visibility-items is not nested underneath row-* along with row-gap. Is this fixable?
|
|
||
| #### CSS | ||
|
|
||
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule. |
There was a problem hiding this comment.
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule. | |
| We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} properties to `repeat(4, 1fr)`, and move the last item to the bottom-right grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule. |
|
|
||
| #### Result | ||
|
|
||
| {{EmbedLiveSample("Basic", "", "230")}} |
There was a problem hiding this comment.
Same comment about adding some margin-left to the list items to stop marker overlap and neaten up the output.
|
|
||
| #### Result | ||
|
|
||
| {{EmbedLiveSample("Basic", "", "230")}} |
There was a problem hiding this comment.
Same comment about adding some margin-left to the list items to stop marker overlap and neaten up the output.
estelle
left a comment
There was a problem hiding this comment.
Good catch at the nav bar. There are several row-* props that are about to be written, so I'll look into making sure they're all there after a few more are added.
| - {{cssxref("column-rule-width")}} | ||
| - {{cssxref("gap")}} | ||
| - {{cssxref("row-gap")}} | ||
| <!-- Will be uncommented when issue https://github.com/mdn/content/issues/44435 is resolved. |
There was a problem hiding this comment.
i removed the comments as the properties are all supported in at least one browser now, even though the docs aren't written yet (they'll be written soon).
chrisdavidmills
left a comment
There was a problem hiding this comment.
@estelle, looks good to go. Just one more minor comment for you to consider, but not blocking on that.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
…/index.md Co-authored-by: Chris Mills <[email protected]>
|
Three new pages:
column-rule-visibility-itemsrow-rule-visibility-itemsrule-visibility-itemsspec: https://drafts.csswg.org/css-gaps-1/#propdef-row-rule-visibility-items
Part of openwebdocs/project#238
EDIT: This PR also uncomments all the hidden props on the module page as they are supported in a released browser. They aren't yet written, but they can't be in a "not supported" paragraph, and our docs should be complete. Working on writing those docs now, so it should be de-redded soon.