Skip to content

New pages: *-rule-visibility-items#44616

Merged
estelle merged 9 commits into
mainfrom
gaps5-rrvi
Jul 3, 2026
Merged

New pages: *-rule-visibility-items#44616
estelle merged 9 commits into
mainfrom
gaps5-rrvi

Conversation

@estelle

@estelle estelle commented Jul 1, 2026

Copy link
Copy Markdown
Member

Three new pages:

  • column-rule-visibility-items
  • row-rule-visibility-items
  • rule-visibility-items

spec: https://drafts.csswg.org/css-gaps-1/#propdef-row-rule-visibility-items

Part of openwebdocs/project#238

EDIT: This PR also uncomments all the hidden props on the module page as they are supported in a released browser. They aren't yet written, but they can't be in a "not supported" paragraph, and our docs should be complete. Working on writing those docs now, so it should be de-redded soon.

@estelle
estelle requested a review from a team as a code owner July 1, 2026 15:36
@estelle
estelle requested review from chrisdavidmills and removed request for a team July 1, 2026 15:36
@github-actions github-actions Bot added Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Jul 1, 2026
@estelle estelle added Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Preview URLs (4 pages)

Flaws (39)

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Web/CSS/Guides/Gaps
Title: CSS gaps
Flaw count: 35

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/column-rule-break which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/column-rule-inset which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/column-rule-inset-cap which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/column-rule-inset-cap-end which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/column-rule-inset-cap-start which doesn't resolve
    • and 30 more flaws omitted

URL: /en-US/docs/Web/CSS/Reference/Properties/column-rule-visibility-items
Title: column-rule-visibility-items CSS property
Flaw count: 1

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/row-rule-visibility-items
Title: row-rule-visibility-items CSS property
Flaw count: 2

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/row-rule which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/rule-visibility-items
Title: rule-visibility-items CSS property
Flaw count: 1

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

(comment last updated: 2026-07-03 08:31:34)

@estelle estelle mentioned this pull request Jul 1, 2026
62 tasks

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle, looking really good. Quite a few comments, but they are mostly language nitpicks that are repeated across all three pages, so not actually that much to do here.

sidebar: cssref
---

The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether a rule segment is painted in portions of gaps adjacent to empty areas, setting both the {{cssxref("column-rule-visibility-items")}} and {{cssxref("row-rule-visibility-items")}} to the same value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether a rule segment is painted in portions of gaps adjacent to empty areas, setting both the {{cssxref("column-rule-visibility-items")}} and {{cssxref("row-rule-visibility-items")}} to the same value.
The **`rule-visibility-items`** [CSS](/en-US/docs/Web/CSS) shorthand property defines whether row-rule and column-rule segments are painted in gaps adjacent to empty areas.

I think this can be cut down, given that the removed info is covered immediately below in the constituent properties section, and in the description.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went with:

The rule-visibility-items CSS shorthand property defines whether rule segments are painted in both row and column gaps adjacent to empty areas.


#### CSS

We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`.
We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} properties to `repeat(4, 1fr)`, and move the last item to the bottom-right grid area using the {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` rules. We set the column rules to `dashed` and the row rules to `solid`.


We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 columns and 4 rows by setting both the {{cssxref("grid-template-columns")}} and {{cssxref("grid-template-rows")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-column")}} and {{cssxref("grid-row")}} properties. We include a {{cssxref("gap")}} of `20px` to provide enough room between the columns to fit our `5px` dashed rule. We set the column rules to `dashed` and the row rules to `solid`.

Finally, we set `rule-visibility-items` to `between`, so only if both grid area adjacent to a column rule segment contains a grid item with the column rule be painted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Finally, we set `rule-visibility-items` to `between`, so only if both grid area adjacent to a column rule segment contains a grid item with the column rule be painted.
Finally, we set `rule-visibility-items` to `between`, so that row- and column-rules are painted only if both grid areas adjacent to them contain a grid item.

This sentence was a bit mixed up; I think I've captured the meaning correctly, but you should check it carefully.


#### Result

{{EmbedLiveSample("Basic", "", "230")}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little demo.

My one nitpick is that the list markers overlap the rules, which looks a bit scruffy. Maybe add some margin-left to the <li>s to stop this from happening?

@@ -0,0 +1,176 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I've noticed is that column-rule-visibility-items is nested underneath column-* in the sidebar, but row-rule-visibility-items is not nested underneath row-* along with row-gap. Is this fixable?


#### CSS

We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} to `repeat(4, 1fr)`, and move the last item to the 16th grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule.
We define the ordered list ({{htmlelement("ol")}}) to be a grid container, creating 4 rows and 4 columns by setting both the {{cssxref("grid-template-rows")}} and {{cssxref("grid-template-columns")}} properties to `repeat(4, 1fr)`, and move the last item to the bottom-right grid area using {{cssxref("grid-row")}} and {{cssxref("grid-column")}}. We include a {{cssxref("gap")}} of `20px` to provide enough room between the rows to fit our `5px` dashed rule.


#### Result

{{EmbedLiveSample("Basic", "", "230")}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about adding some margin-left to the list items to stop marker overlap and neaten up the output.


#### Result

{{EmbedLiveSample("Basic", "", "230")}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about adding some margin-left to the list items to stop marker overlap and neaten up the output.

@estelle estelle left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch at the nav bar. There are several row-* props that are about to be written, so I'll look into making sure they're all there after a few more are added.

@estelle
estelle requested a review from chrisdavidmills July 2, 2026 08:46
- {{cssxref("column-rule-width")}}
- {{cssxref("gap")}}
- {{cssxref("row-gap")}}
<!-- Will be uncommented when issue https://github.com/mdn/content/issues/44435 is resolved.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed the comments as the properties are all supported in at least one browser now, even though the docs aren't written yet (they'll be written soon).

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle, looks good to go. Just one more minor comment for you to consider, but not blocking on that.

Comment thread files/en-us/web/css/reference/properties/rule-visibility-items/index.md Outdated
@github-actions github-actions Bot added the merge conflicts 🚧 [PR only] label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions Bot removed the merge conflicts 🚧 [PR only] label Jul 3, 2026
@estelle
estelle merged commit 34838ae into main Jul 3, 2026
13 checks passed
@estelle
estelle deleted the gaps5-rrvi branch July 3, 2026 08:32
@babumiah7148-collab

Copy link
Copy Markdown

Three new pages:

  • column-rule-visibility-items
  • row-rule-visibility-items
  • rule-visibility-items

spec: https://drafts.csswg.org/css-gaps-1/#propdef-row-rule-visibility-items

Part of openwebdocs/project#238

EDIT: This PR also uncomments all the hidden props on the module page as they are supported in a released browser. They aren't yet written, but they can't be in a "not supported" paragraph, and our docs should be complete. Working on writing those docs now, so it should be de-redded soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants