Conversation
|
Preview URLs (1 page) Flaws (10) Found an unexpected or unresolvable flaw? Please report it here. URL:
(comment last updated: 2026-07-15 10:54:28) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Excellent work, @estelle. This is mostly really nice and clear, and the comments are not particularly major.
| - : A {{cssxref("repeat()")}} function, with the first parameter being an {{cssxref("<integer>")}} of `1` or more, representing the number of the times the second parameter, a {{cssxref("<color>")}} value, should be repeated. | ||
|
|
||
| - `<auto-repeat-line-color>` | ||
| - : A {{cssxref("repeat()")}} function, with `auto` as the first argument and a `<color>` as the second, representing the color to be repeated as many times as needed to fill in values for any row-rules that would not otherwise receive values from other parts of the property value. |
There was a problem hiding this comment.
Hrm, this is tricky to explain. It took me a little while to grok this. Would the following help, do you think?
| - : A {{cssxref("repeat()")}} function, with `auto` as the first argument and a `<color>` as the second, representing the color to be repeated as many times as needed to fill in values for any row-rules that would not otherwise receive values from other parts of the property value. | |
| - : A {{cssxref("repeat()")}} function, with `auto` as the first argument and a `<color>` as the second, representing a color to be repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value. |
There was a problem hiding this comment.
should actually be a list of colors.
A {{cssxref("repeat()")}} function, with
autoas the first argument and a<color>as the second, representing one or more comma-separated<color>values to be repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value.
Co-authored-by: Chris Mills <[email protected]>
| row-rule-color: blue; | ||
| ``` | ||
|
|
||
| When more than one `<line-color>` is declared, they will be applied to row-rules in the order specified. If there are more row-rules than `<line-color> values, the list of line colors is repeated until every row rule has a color. If we declare the following, for example, every odd rule will be blue, and every even rule will be yellow. |
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
error MD033/no-inline-html Inline HTML [Element: line-color]
chrisdavidmills
left a comment
There was a problem hiding this comment.
@estelle, a few more comments for you, mainly around the issue of repeat() being able to accept multiple colors, not just one.
|
|
||
| ### Auto-repeating line colors | ||
|
|
||
| The `repeat()` function also accepts `auto` as the first argument instead of a positive integer. With `auto` as the first argument, the `<color>` passed as the second will be repeated as many times as needed to fill in values for any row-rules that are not explicitly specified by other components of the property value, if any. |
There was a problem hiding this comment.
This section needs to cover the fact that auto can be combined with multiple <color> values.
| - : A {{cssxref("<color>")}} representing the color of the line. | ||
|
|
||
| - `<repeat-line-color>` | ||
| - : A {{cssxref("repeat()")}} function, with the first parameter being an {{cssxref("<integer>")}} of `1` or more, representing the number of the times the second parameter, a {{cssxref("<color>")}} value, should be repeated. |
There was a problem hiding this comment.
repeat() can accept multiple color values, not just one?
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
chrisdavidmills
left a comment
There was a problem hiding this comment.
@estelle I've got a few more comments for you, but they are pretty minor. I will approve, as I don't think I need to see this again. Nice work.
| row-rule-color: blue, repeat(auto, yellow), red; | ||
| ``` | ||
|
|
||
| In this case, the first row rule will be blue, the last will be red, and all others will be yellow. It doesn't matter if the container has 3, 6, 11, 16, or 21 rows; the first will always be blue and, as long as there are at least two row-rules, the last will always be red. All the other row rules will be yellow, which means if there are only 2 or 3 rows, there will be no yellow row rules. |
There was a problem hiding this comment.
I've noticed an inconsistency in the text: "row-rule" versus "row rule". I'd suggest choosing one, then making it consistent everywhere. I personally think "row rule" is better grammatically when referring to the concept rather than the property name, but I don't really care that much which one we go with.
Co-authored-by: Chris Mills <[email protected]>
new page.
Looking to get feedback/approval before updating/creating other row-rule, all the column-rule, and rule shorthand properties.
because of this, some links might be red (page not created yet), and module landing not being updated until i add several pages. please don't hold up review / approval for issues of red links for CSS gaps properties
Part of openwebdocs/project#238