Skip to content

fix(jsondata/SVGData): remove discard#42836

Merged
pepelsbey merged 1 commit intomainfrom
remove-discard-from-SVGData
Jan 20, 2026
Merged

fix(jsondata/SVGData): remove discard#42836
pepelsbey merged 1 commit intomainfrom
remove-discard-from-SVGData

Conversation

@caugner
Copy link
Copy Markdown
Collaborator

@caugner caugner commented Jan 20, 2026

Description

Removes the SVG <discard> element from SVGData.json.

Motivation

This was causing issues/flaws, because the discard element page got removed, and now redirects to the SVG Element overview.

(This also means <discard> in https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Element/linearGradient#usage_context points to the overview.)

Additional details

Related issues and pull requests

Noticed in #42834.

Related to #39618.

This was causing issues/flaws, because the discard element page
got removed, and now redirects to the SVG Element overview.
@caugner caugner requested a review from a team as a code owner January 20, 2026 12:12
@caugner caugner requested review from pepelsbey and removed request for a team January 20, 2026 12:12
@github-actions github-actions Bot added the size/m [PR only] 51-500 LoC changed label Jan 20, 2026
Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙂

I wonder if we could’ve done anything differently when removing <discard> so this data would be cleaned up as well.

@pepelsbey pepelsbey merged commit 031a94b into main Jan 20, 2026
10 checks passed
@pepelsbey pepelsbey deleted the remove-discard-from-SVGData branch January 20, 2026 18:08
@caugner
Copy link
Copy Markdown
Collaborator Author

caugner commented Jan 21, 2026

I wonder if we could’ve done anything differently when removing <discard> so this data would be cleaned up as well.

In theory, we could lint the jsondata files, similar to how we lint the sidebars. But it would be more complex, as each jsondata file is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants