Skip to content

Comments

MDN intro to client-side frameworks update: intro & framework main features#30515

Merged
chrisdavidmills merged 15 commits intomdn:mainfrom
mxmason:ej/frameworks-rewrite-1
Nov 30, 2023
Merged

MDN intro to client-side frameworks update: intro & framework main features#30515
chrisdavidmills merged 15 commits intomdn:mainfrom
mxmason:ej/frameworks-rewrite-1

Conversation

@mxmason
Copy link
Contributor

@mxmason mxmason commented Nov 24, 2023

Description

As part of mdn/mdn#474, this PR introduces some minor edits to the "Introduction to client-side frameworks" and "framework main features" lessons.

@github-actions github-actions bot added the Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees label Nov 24, 2023
Copy link
Contributor Author

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All yours, @chrisdavidmills! Wasn't sure if this one should be a do not merge, since its changes can stand alone (I think)

@mxmason mxmason marked this pull request as ready for review November 24, 2023 22:05
@mxmason mxmason requested a review from a team as a code owner November 24, 2023 22:05
@mxmason mxmason requested review from hamishwillee and removed request for a team November 24, 2023 22:05
Copy link
Contributor Author

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more! I decided that the changes to these files were small enough that they can go together, maybe

@mxmason mxmason changed the title MDN client-side frameworks #1: Intro MDN intro to client-side frameworks update: intro & framework main features Nov 24, 2023
@chrisdavidmills chrisdavidmills requested review from chrisdavidmills and removed request for hamishwillee November 28, 2023 14:24
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxmason hey, nice work here! I have looked through it all, and mostly offered feedback by way of responses to your existing comments. I also noticed the following small bits:

First article:

Second article:

  • Another line number reference - "The curly braces around subject on line 4". Maybe change to "The curly braces around {subject}" ?
  • Another one - "We call this function on line 4, and set count to whatever its current value is, plus one". Maybe change it to "We call this function inside the onClick event handler, setting count to whatever its current value is, plus one" ?

Copy link
Contributor Author

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to you, @chrisdavidmills! I've also updated my CodePen to use the textContent property instead of createTextNode()

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxmason ok, I think this looks fine, pending the nitpick about the object capitalization. Let me know what you think on that one.

I think we'll get this merged in the next round regardless, as you are right — this isn't dependant on the rest of your work.

@mxmason
Copy link
Contributor Author

mxmason commented Nov 30, 2023

Heya, @chrisdavidmills. I'd like to merge this as-is if you're ok with the way things are capitalized now.

I also know I have other reviews to get to, but I've not been well today. I'll get back to you tomorrow, i hope!

@chrisdavidmills
Copy link
Contributor

Heya, @chrisdavidmills. I'd like to merge this as-is if you're ok with the way things are capitalized now.

OK, let's do this!

I also know I have other reviews to get to, but I've not been well today. I'll get back to you tomorrow, i hope!

Wishing you better health very soon.

@chrisdavidmills chrisdavidmills merged commit 03f2475 into mdn:main Nov 30, 2023
estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
…atures (mdn#30515)

* chore: replace createTextElement with textContent

* chore: update line of code estimation

* chore: capitalize Node interface

* chore: update ssg links

* chore: fix Tatiana's pronouns

* chore: use jsx syntax in code blocks where appropriate

* chore: update jsx example

* chore: update test code

* chore: update rest of text code

oops. no one look at me

* chore: fix test block syntax

* chore: clean up some copy

* chore: small cleanup

* Update JS feature references

---------

Co-authored-by: Chris Mills <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants