MDN intro to client-side frameworks update: intro & framework main features#30515
MDN intro to client-side frameworks update: intro & framework main features#30515chrisdavidmills merged 15 commits intomdn:mainfrom mxmason:ej/frameworks-rewrite-1
Conversation
mxmason
left a comment
There was a problem hiding this comment.
All yours, @chrisdavidmills! Wasn't sure if this one should be a do not merge, since its changes can stand alone (I think)
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
mxmason
left a comment
There was a problem hiding this comment.
One more! I decided that the changes to these files were small enough that they can go together, maybe
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/main_features/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/main_features/index.md
Show resolved
Hide resolved
chrisdavidmills
left a comment
There was a problem hiding this comment.
@mxmason hey, nice work here! I have looked through it all, and mostly offered feedback by way of responses to your existing comments. I also noticed the following small bits:
First article:
- The functional version of your raw JS example at https://codepen.io/mxmason/pen/XWbPNmw needs updating to match the code changes you made in the doc.
Second article:
- Another line number reference - "The curly braces around
subjecton line 4". Maybe change to "The curly braces around{subject}" ? - Another one - "We call this function on line 4, and set
countto whatever its current value is, plus one". Maybe change it to "We call this function inside theonClickevent handler, settingcountto whatever its current value is, plus one" ?
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/main_features/index.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Back to you, @chrisdavidmills! I've also updated my CodePen to use the textContent property instead of createTextNode()
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/introduction/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/main_features/index.md
Show resolved
Hide resolved
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/main_features/index.md
Show resolved
Hide resolved
chrisdavidmills
left a comment
There was a problem hiding this comment.
@mxmason ok, I think this looks fine, pending the nitpick about the object capitalization. Let me know what you think on that one.
I think we'll get this merged in the next round regardless, as you are right — this isn't dependant on the rest of your work.
|
Heya, @chrisdavidmills. I'd like to merge this as-is if you're ok with the way things are capitalized now. I also know I have other reviews to get to, but I've not been well today. I'll get back to you tomorrow, i hope! |
OK, let's do this!
Wishing you better health very soon. |
…atures (mdn#30515) * chore: replace createTextElement with textContent * chore: update line of code estimation * chore: capitalize Node interface * chore: update ssg links * chore: fix Tatiana's pronouns * chore: use jsx syntax in code blocks where appropriate * chore: update jsx example * chore: update test code * chore: update rest of text code oops. no one look at me * chore: fix test block syntax * chore: clean up some copy * chore: small cleanup * Update JS feature references --------- Co-authored-by: Chris Mills <[email protected]>
Description
As part of mdn/mdn#474, this PR introduces some minor edits to the "Introduction to client-side frameworks" and "framework main features" lessons.