Skip to content

Comments

MDN React Tutorials #3: Componentizing#30514

Merged
chrisdavidmills merged 28 commits intomdn:mainfrom
mxmason:ej/react-rewrite-3
Dec 21, 2023
Merged

MDN React Tutorials #3: Componentizing#30514
chrisdavidmills merged 28 commits intomdn:mainfrom
mxmason:ej/react-rewrite-3

Conversation

@mxmason
Copy link
Contributor

@mxmason mxmason commented Nov 24, 2023 •
edited by chrisdavidmills
Loading

Description

Following #30453 as part of mdn/mdn#474, this PR makes some modifications to the third page in our "Getting started with React" tutorial.

Do not merge this until #30453 has been merged and you have updated this PR with mdn main and checked for breakages.

@github-actions github-actions bot added the Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees label Nov 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2023 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_components
Title: Componentizing our React app

(comment last updated: 2023-12-21 11:16:06)

mxmason
mxmason commented Nov 24, 2023
View reviewed changes
Copy link
Contributor Author

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A gift just for you, @chrisdavidmills! This file has undergone some light editing apart from just changing .js to .jsx. I've tried to call out things of note.

@mxmason mxmason marked this pull request as ready for review November 24, 2023 19:41
@mxmason mxmason requested a review from a team as a code owner November 24, 2023 19:41
@mxmason mxmason requested review from hamishwillee and removed request for a team November 24, 2023 19:41
@queengooborg queengooborg marked this pull request as draft November 25, 2023 07:33
@mxmason mxmason marked this pull request as ready for review November 26, 2023 20:30
@mxmason mxmason mentioned this pull request Nov 27, 2023
Merged
@chrisdavidmills chrisdavidmills mentioned this pull request Nov 28, 2023
Closed
10 tasks
chrisdavidmills
chrisdavidmills requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More fabulous work, thank you @mxmason! Some comments for you to chew on.

mxmason
mxmason commented Dec 1, 2023
View reviewed changes
Copy link
Contributor Author

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to you, @chrisdavidmills!

I addressed your notes (I think), plus a couple of other small changes – removing props from the signature of FilterButton and wrapping <FilterButton /> in code code markup in its heading, among other changes.

@hamishwillee hamishwillee removed their request for review December 11, 2023 03:26
@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 11, 2023

@chrisdavidmills I'm removing myself as a reviewer - I know nothing about React.

chrisdavidmills
chrisdavidmills approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work @mxmason! I made a couple of very small tweaks to push this over the finish line; I thought you'd appreciate that rather than passing it back to you for another round.

With that, I'm approving this, and you can move on to the next one.

@bsmth bsmth added the do not merge [PR only] Not ready to land label Dec 13, 2023
@chrisdavidmills chrisdavidmills mentioned this pull request Dec 15, 2023
Merged
@chrisdavidmills chrisdavidmills removed the do not merge [PR only] Not ready to land label Dec 21, 2023
@chrisdavidmills chrisdavidmills changed the title DO NOT MERGE: MDN React Tutorials #3: Componentizing MDN React Tutorials #3: Componentizing Dec 21, 2023
@chrisdavidmills chrisdavidmills merged commit 4baa9df into mdn:main Dec 21, 2023
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@mxmason @chrisdavidmills @dipikabh
MDN React Tutorials #3: Componentizing (mdn#30514)
11914a5 
* chore: .js --> .jsx

* chore: remove unnecessary react import

* chore: clean up todo markup

* chore: remove undefined return warning

* chore: tweak props rendering instructions

* chore: better explain id collision

* chore: index.jsx --> main.jsx

* chore: use optional chaining consistently

* chore: use implicit boolean for completed

* nit: a word

* chore: remove default react import

* chore: remove unused props

* chore: edit jsx note

* chore: use brace expansion in bash command

* chore: add eslint note

* chore: fix todo code snippet

* chore: edit final import instructions

* Small text tweaks

* chore: apply suggestions from code review

Co-authored-by: Chris Mills <[email protected]>

* chore: apply suggestions from code review

Co-authored-by: Chris Mills <[email protected]>

* chore: update "make a todo" instructions

* clean up "id please" section

* chore: clean up "tasks as data"

* chore: small cleanup

* Small grammar fix

* Small tweak

---------

Co-authored-by: Chris Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees

No one assigned

Labels

Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mxmason @hamishwillee @chrisdavidmills @bsmth