Add missing CSSLayer*Rule interfaces#24124
Merged
Conversation
Contributor
|
Preview URLs
(comment last updated: 2023-03-15 05:17:12) |
estelle
reviewed
Feb 3, 2023
estelle
reviewed
Feb 3, 2023
estelle
reviewed
Feb 3, 2023
estelle
reviewed
Feb 3, 2023
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
teoli2003
commented
Feb 8, 2023
Contributor
Author
|
I think this is good now |
Member
|
@estelle Note to self: check this. |
Elchi3
approved these changes
Mar 14, 2023
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Just some nits. LGTM otherwise
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
estelle
approved these changes
Mar 15, 2023
Member
estelle
left a comment
estelle
left a comment
There was a problem hiding this comment.
Sorry for the delay. the note to myself didn't work ;)
Co-authored-by: Florian Scholz <[email protected]>
Contributor
Author
No worry, this was not blocking anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of openwebdocs/project#152, here is the addition of the missing
CSSLayerStatementRuleandCSSLayerBlockRuleparts of the Cascade Layer feature. With this PR, all cascade layers APIs are documented.Spec link: https://drafts.csswg.org/css-cascade-5/#layer-apis