Skip to content

Comments

added level #2 HTML#23438

Merged
dipikabh merged 6 commits intomdn:mainfrom
TjasaZil:stacking-context-example-3-issue-23274
Jan 11, 2023
Merged

added level #2 HTML#23438
dipikabh merged 6 commits intomdn:mainfrom
TjasaZil:stacking-context-example-3-issue-23274

Conversation

@TjasaZil
Copy link
Contributor

@TjasaZil TjasaZil commented Jan 6, 2023

Description

I added a few more level 2 divs, in order to better illustrate the example.

Motivation

The example is more understandable, based on the description above the code.

Related issues and pull requests

Fix #23274

@TjasaZil TjasaZil requested a review from a team as a code owner January 6, 2023 17:16
@TjasaZil TjasaZil requested review from dipikabh and removed request for a team January 6, 2023 17:16
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Preview URLs

(comment last updated: 2023-01-10 16:22:00)

@dipikabh dipikabh self-assigned this Jan 6, 2023
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zuzexx, the author in the issue is referring to the list in the Description section, under the sentence "To better understand the situation, here is the stacking context hierarchy:". This list contains the three dots for illustration purposes.

Even if you try to improve the code snippets, I believe the list with three dots, which is causing the confusion, still exists.

Could you make corresponding updates to the list to remove the three dots and also to match your new example?

@TjasaZil
Copy link
Contributor Author

TjasaZil commented Jan 6, 2023

I can do the changes. Just that I understand correctly, you want me to change the three dots between level 2 divs to the appropriate amount of divs so that it reflects the new example?

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, we don't need to remove the ellipsis. We can clarify the use of ellipsis in the description.

How about updating the following line as:

line 28: "To better understand the situation, the following example illustrates the stacking context hierarchy (the three dots "..." represent multiple repetition of the previous line):


- LEVEL #2 (`z-index`: 1)
-
- LEVEL #2 (`z-index`: 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- LEVEL #2 (`z-index`: 1)

let's keep the ellipsis


- LEVEL #1
-
- LEVEL #1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- LEVEL #1

let's keep the ellipsis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you for clarification. I will get to it once I come home.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zuzexx! 👍

@dipikabh dipikabh merged commit eb4185d into mdn:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacking context example 3, stacking context hierarchy misinformation

2 participants