Add more details to crossOriginIsolated property#23275
Merged
Conversation
NiedziolkaMichal
requested review from
jpmedley
and removed request for
a team
Contributor
|
Preview URLs
Flaws (3)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
(comment last updated: 2023-01-02 12:50:40) |
Elchi3
requested changes
Jan 2, 2023
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for your PR. I have some suggestions.
In the code example it also says "Post SharedArrayBuffer" maybe we want to say something more generic there, too.
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Member
Author
|
Thank you for the review. const myWorker = new Worker('worker.js');
if (crossOriginIsolated) {
const buffer = new SharedArrayBuffer(16);
myWorker.postMessage(buffer);
} else {
const buffer = new ArrayBuffer(16);
myWorker.postMessage(buffer);
} |
Member
|
yeah, that looks like a good idea. Always great to show code that isn't just theory. |
Member
Author
|
Thank you too |
ArthurSonzogni
added a commit
to ArthurSonzogni/mdn-content
that referenced
this pull request
Jan 3, 2023
This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - mdn#8871 - mdn#23097 - mdn#23275 Follow-up:
ArthurSonzogni
added a commit
to ArthurSonzogni/mdn-content
that referenced
this pull request
Jan 3, 2023
This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - mdn#8871 - mdn#23097 - mdn#23275
Elchi3
pushed a commit
that referenced
this pull request
Jan 4, 2023
* Document COEP:credentialless This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - #8871 - #23097 - #23275 * Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md Co-authored-by: Chris Mills <[email protected]> * Address Chris #2 comment. * Address @Elchi3 suggestions. Co-authored-by: Chris Mills <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some more details to crossOriginIsolated property. I have checked the required header values by manual test in Chrome, but they are also listed in the specification. I have found the unlocked features by reading web.dev article and checked MDN existing pages.