update types on formatToParts#20127
Merged
hamishwillee merged 4 commits intomdn:mainfrom Nov 6, 2022
Merged
Conversation
Contributor
|
Preview URLs (this comment was updated 2022-11-06 22:31:43.982202) |
Josh-Cena
reviewed
Aug 30, 2022
|
|
||
| Possible types are the following: | ||
|
|
||
| - compact |
Member
There was a problem hiding this comment.
Not introduced by your PR, but could you add code formatting to every type?
| - : The unit string, such as the "l" or "litres", depending on how | ||
| `unitDisplay` is specified. | ||
| - unknown | ||
| - : The string for `unknown` type results |
…rformat/formattoparts/index.md Co-authored-by: Joshua Chen <[email protected]>
Member
|
@romulocintra We're not in a hurry since we are working on a 1.5 year old issue anyway, but do you plan to add an example with |
Member
|
Pinging @romulocintra in case you are interested in finishing this up. Otherwise I would push to the branch myself. |
Josh-Cena
added
the
awaiting response
hamishwillee
approved these changes
Nov 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #516 by adding missing types to NumberFormat/formatToParts
Motivation
Supporting details
https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/proposed.html#sec-partitionnumberpattern
Related issues
Metadata