Skip to content

Comments

pr-build workflow#2

Merged
peterbe merged 11 commits intomainfrom
pr-build-workflow
Sep 15, 2020
Merged

pr-build workflow#2
peterbe merged 11 commits intomainfrom
pr-build-workflow

Conversation

@peterbe
Copy link
Contributor

@peterbe peterbe commented Sep 15, 2020

No description provided.

@peterbe peterbe marked this pull request as ready for review September 15, 2020 20:55
@peterbe
Copy link
Contributor Author

peterbe commented Sep 15, 2020

@escattone I'm going to r=me merge this because I'm fairly confident it works and there's not a lot to discuss. If it doesn't work, we'll find out over time.
Basically, if there's an edit to any file in the files/**/index.html, it does things. The first thing it does is a crisp git clone of the master branch of Yari to be the builder.
There's definitely a small risk with this which is that a writer might have been using an old copy of @mdn/yari in here local testing but when it becomes a PR it uses the master branch of Yari which could yield different results.
However, we have all the Dependabot and auto-merge workflow stuff set up so that every time there's a commit to master on Yari, it generates a new NPM release and moments later, Dependbot will update this repo and with a PR which is auto-merged.

What might be interesting is to do more cool stuff after the yarn build such as uploading them with the deployer. Now, there's a new home for where that would go.

Another interesting idea is to open every single page that gets built and take a screenshot of each page and then upload those screenshots as file attachments to a PR comment. That would be cool as ice!

@peterbe peterbe merged commit e7c50f5 into main Sep 15, 2020
@peterbe peterbe deleted the pr-build-workflow branch September 15, 2020 21:26
@chrisdavidmills chrisdavidmills mentioned this pull request Jan 7, 2021
Closed
@spanezz spanezz mentioned this pull request Feb 9, 2021
Closed
@voronamanga voronamanga mentioned this pull request Mar 11, 2021
Closed
@wbamberg wbamberg mentioned this pull request Mar 26, 2021
Closed
@wdporter wdporter mentioned this pull request Apr 15, 2021
Closed
jpmedley added a commit that referenced this pull request Sep 9, 2021
@rachelandrew @jpmedley
Adds CustomStateSet (#8093)
59e9fd4 
* Adds CustomStateSet

* Adding set methods (#2)

* Adding set methods

* case

* and back

* Apply suggestions from code review

Co-authored-by: Joe Medley <[email protected]>

Co-authored-by: Joe Medley <[email protected]>
@wbamberg wbamberg mentioned this pull request Jan 11, 2022
Closed
3 tasks
teoli2003 added a commit that referenced this pull request Apr 4, 2022
@teoli2003
Replace {{event)}} with domxref (batch #2) (#14578)
ce44990 
* Replace {{event)}} with domxref

* icegatherstatechange

* Fix payerdetailchange event.
@greggman greggman mentioned this pull request Apr 11, 2022
Open
estelle added a commit that referenced this pull request Jun 13, 2022
@estelle @ericwbailey
New page: aria-modal (#12559)
c8ed891 
* New page: aria-modal

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

Co-authored-by: Eric Bailey <[email protected]>

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

Co-authored-by: Eric Bailey <[email protected]>

* addressed comment #2

* inert

* removed sentence

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

* Update files/en-us/web/accessibility/aria/attributes/aria-modal/index.md

Co-authored-by: Eric Bailey <[email protected]>
teoli2003 added a commit that referenced this pull request Jun 29, 2022
@estelle @teoli2003
Page Delete (#17765)
f3fc462 
* Page Delete

* Fix redirect (tentative)

* Attempt #2

Co-authored-by: Jean-Yves Perrier <[email protected]>
wbamberg pushed a commit that referenced this pull request Jul 1, 2022
#2 Make all TypedArray constructor examples consistent (#17831)
5b776a0 
* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md
Josh-Cena added a commit that referenced this pull request Jul 15, 2022
@Josh-Cena
Function - Rename properties and methods to include prototype (#1…
10e9198 
…8200)

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* revert toString

* Revert call

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Shorten jsxref

* Shorten jsxref

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Use template string

* Update index.md

* Update index.md

* Attempt fixing link

* Attempt #2

* Revert, and attempt fixing flaw

* Update index.md

* Flaw fix

* Update index.md

* Fix flaw

* Fix flaw

* Fix flaw

* Fix flaw

* Insert missing comma

* Drop ES5

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/javascript/reference/global_objects/function/apply/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Drop array syntax comments

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/javascript/reference/global_objects/function/name/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update /apply note

Co-authored-by: Joshua Chen <[email protected]>

* Update /bind note

* Update /call note

* Apply suggestions from code review

* Update index.md

* Update index.md

* Update index.md

* fixes

* more fixes

Co-authored-by: Joshua Chen <[email protected]>
@angelayanpan angelayanpan mentioned this pull request Jul 26, 2022
Closed
Josh-Cena added a commit that referenced this pull request Sep 2, 2022
@teoli2003 @Josh-Cena @rubiesonthesky
Avoid classical for when looping through all items of an Array-like o…
24f9f75 
…bject (part #2) (#19405)

* Avoid classical for if for...of when looping all object of an Array-like object

* Remove addictions from MDN

* Add checkPerformanceEntry

* Use same example

* Use same example

* Fix naming

* Fix names

* Fix name

* Fix name

* Fix name

* Fix name

* Rename function

* Rename function

* Fix name

* Fix name

* Remove useless const

* Remove useless variable

* fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Remove useless variable

* Remove useless variable

* Remove useless variable

* Remove useless varaible

* Rename function

* fix function name

* Fix function name

* Fix function name

* Fix function name

* Add empty line

* Fix function names

* Update files/en-us/web/api/performanceresourcetiming/decodedbodysize/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Fix function names

* Fix function name

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* fix function names

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* Use ternary operator

* Fix function names

* Use method

* Update files/en-us/web/api/texttrack/mode/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/speechsynthesisvoice/name/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Readd example

* readd example

* Add workerStart to the list

* Replace for…in

* Use findIndex()

* Use findIndex()

* Fix function names (no _)

* Fix alignement + for…in

* Alignment

* Update files/en-us/web/api/performanceresourcetiming/transfersize/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Update files/en-us/web/api/performanceresourcetiming/connectstart/index.md

* Use ??

* Use ??

* Remove empty space

* Remove space

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Apply suggestions from code review

* Use console.log

* Use console.log

* Use console.log

* Use console.log

* Use console.log

* console.log

* console.log

* Apply suggestions from code review

* Update index.md

* Update index.md

* Update index.md

* Remove useless variable

* Fix typo

* Use findLastIndex()

* Update index.md

* Update index.md

Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: rubiesonthesky <[email protected]>
goshdarnheck pushed a commit to goshdarnheck/content that referenced this pull request Sep 7, 2022
@teoli2003 @Josh-Cena
@rubiesonthesky @goshdarnheck
Avoid classical for when looping through all items of an Array-like o…
5d945bd 
…bject (part mdn#2) (mdn#19405)

* Avoid classical for if for...of when looping all object of an Array-like object

* Remove addictions from MDN

* Add checkPerformanceEntry

* Use same example

* Use same example

* Fix naming

* Fix names

* Fix name

* Fix name

* Fix name

* Fix name

* Rename function

* Rename function

* Fix name

* Fix name

* Remove useless const

* Remove useless variable

* fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Fix name

* Remove useless variable

* Remove useless variable

* Remove useless variable

* Remove useless varaible

* Rename function

* fix function name

* Fix function name

* Fix function name

* Fix function name

* Add empty line

* Fix function names

* Update files/en-us/web/api/performanceresourcetiming/decodedbodysize/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Fix function names

* Fix function name

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* fix function names

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* Fix function names

* Use ternary operator

* Fix function names

* Use method

* Update files/en-us/web/api/texttrack/mode/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance/getentriesbytype/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Update files/en-us/web/api/speechsynthesisvoice/name/index.md

Co-authored-by: rubiesonthesky <[email protected]>

* Readd example

* readd example

* Add workerStart to the list

* Replace for…in

* Use findIndex()

* Use findIndex()

* Fix function names (no _)

* Fix alignement + for…in

* Alignment

* Update files/en-us/web/api/performanceresourcetiming/transfersize/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Update files/en-us/web/api/performanceresourcetiming/connectstart/index.md

* Use ??

* Use ??

* Remove empty space

* Remove space

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Use ??

* Apply suggestions from code review

* Use console.log

* Use console.log

* Use console.log

* Use console.log

* Use console.log

* console.log

* console.log

* Apply suggestions from code review

* Update index.md

* Update index.md

* Update index.md

* Remove useless variable

* Fix typo

* Use findLastIndex()

* Update index.md

* Update index.md

Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: rubiesonthesky <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@peterbe