Skip to content

Comments

Correction for the formal syntax not found issue - 02#19416

Merged
wbamberg merged 8 commits intomainfrom
unknown repository
Aug 31, 2022
Merged

Correction for the formal syntax not found issue - 02#19416
wbamberg merged 8 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 11, 2022 •
edited by ghost
Loading

This is the 2th part for the issue #18780
In this PR I covered these instances:

  • box-align
  • box-direction
  • box-flex
  • box-flex-group
  • box-lines
  • box-ordinal-group
  • box-orient
  • box-pack
  • font-smooth
  • ime-mode
  • scroll-snap-coordinate
  • scroll-snap-destination
  • scroll-snap-points-x
  • scroll-snap-points-y
  • scroll-snap-type-x
  • scroll-snap-type-y
  • zoom

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@ghost ghost self-requested a review as a code owner August 11, 2022 15:45
@ghost ghost requested review from estelle and removed request for a team August 11, 2022 15:45
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 11, 2022
@ghost ghost changed the title Correction for the formal syntax not found issue -2th part Correction for the formal syntax not found issue - 02 Aug 12, 2022
@ghost ghost self-requested a review as a code owner August 15, 2022 15:04
@ghost ghost requested review from jpmedley and removed request for a team August 15, 2022 15:04
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 15, 2022
@github-actions github-actions bot removed Content:WebAPI Web API docs Content:CSS Cascading Style Sheets docs labels Aug 15, 2022
@ghost ghost marked this pull request as draft August 15, 2022 15:17
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 20, 2022
@ghost ghost marked this pull request as ready for review August 20, 2022 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 15 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/box-lines
Title: box-lines
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/box-flex-groups does not exist

External URLs

URL: /en-US/docs/Web/CSS/scroll-snap-coordinate
Title: scroll-snap-coordinate
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-align
Title: box-align
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/font-smooth
Title: font-smooth
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/ime-mode
Title: ime-mode
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-orient
Title: box-orient
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-lines
Title: box-lines
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-direction
Title: box-direction
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-flex
Title: box-flex
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/scroll-snap-points-x
Title: scroll-snap-points-x
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/scroll-snap-type-y
Title: scroll-snap-type-y
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-pack
Title: box-pack
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/scroll-snap-points-y
Title: scroll-snap-points-y
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-flex-group
Title: box-flex-group
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/scroll-snap-destination
Title: scroll-snap-destination
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/zoom
Title: zoom
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-ordinal-group
Title: box-ordinal-group
on GitHub

No new external URLs

(this comment was updated 2022-08-30 23:58:32.658834)

@ghost ghost mentioned this pull request Aug 20, 2022
Closed
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg reviewed Aug 30, 2022
View reviewed changes
wbamberg
wbamberg approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @najmiehsa !

@wbamberg wbamberg merged commit 230360d into mdn:main Aug 31, 2022
@ghost
Copy link
Author

ghost commented Aug 31, 2022

Thanks^^

@ghost ghost deleted the F2syntax branch August 31, 2022 04:26
goshdarnheck pushed a commit to goshdarnheck/content that referenced this pull request Sep 7, 2022
@de-oz @wbamberg @goshdarnheck
Correction for the formal syntax not found issue - 02 (mdn#19416)
1ec719a 
* Fix incorrect indefinite article usage (part mdn#3) (mdn#19409)

* Revert "Fix incorrect indefinite article usage (part mdn#3) (mdn#19409)"

This reverts commit 4e694e0.

* Fix for the formal syntax

* Fix for the formal syntax

* Fix code review comments

* Consistently indent with 2 spaces

Co-authored-by: de-oz <[email protected]>
Co-authored-by: Will Bamberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estelle estelle Awaiting requested review from estelle estelle was automatically assigned from mdn/yari-content-css

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley was automatically assigned from mdn/yari-content-web-api

Assignees

No one assigned

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wbamberg @de-oz