Avoid classical for when looping through all items of an Array-like object (part #2)#19405
Merged
Avoid classical for when looping through all items of an Array-like object (part #2)#19405
Conversation
teoli2003
requested review from
a team,
Josh-Cena,
jpmedley and
sideshowbarker
and removed request for
a team,
jpmedley and
sideshowbarker
This comment was marked as resolved.
This comment was marked as resolved.
teoli2003
changed the title
Josh-Cena
requested changes
Aug 12, 2022
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Not a thorough review; would go over this again after the initial reviews are addressed
files/en-us/web/api/performancenavigationtiming/dominteractive/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performanceresourcetiming/decodedbodysize/index.md
Outdated
Show resolved
Hide resolved
teoli2003
requested review from
Josh-Cena
and removed request for
rubiesonthesky
Josh-Cena
reviewed
Aug 23, 2022
Contributor
Author
|
@Josh-Cena When you have time, can you double-check this PR? I think I have fixed all the review comments. |
Member
|
Sorry for being a little slow. My academic life is picking up and I don't always have access to a computer this week. This PR has a lot of moving parts and reviewing takes some mental energy. I'll try setting aside some time tomorrow. |
Contributor
Author
No worry, I guessed your academic life started again. Take your time. |
files/en-us/web/api/touch_events/multi-touch_interaction/index.md
Outdated
Show resolved
Hide resolved
Contributor
|
I have no further comments. I don't know enough of some of the code examples to be able to review if they are correct or not, though they seem good for me. |
Josh-Cena
approved these changes
Sep 2, 2022
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Sorry for being so slow to get to this. This looks great to me (had to go through a lot of code that looks almost the same...)
goshdarnheck
pushed a commit
to goshdarnheck/content
that referenced
this pull request
Sep 7, 2022
…bject (part mdn#2) (mdn#19405) * Avoid classical for if for...of when looping all object of an Array-like object * Remove addictions from MDN * Add checkPerformanceEntry * Use same example * Use same example * Fix naming * Fix names * Fix name * Fix name * Fix name * Fix name * Rename function * Rename function * Fix name * Fix name * Remove useless const * Remove useless variable * fix name * Fix name * Fix name * Fix name * Fix name * Fix name * Fix name * Remove useless variable * Remove useless variable * Remove useless variable * Remove useless varaible * Rename function * fix function name * Fix function name * Fix function name * Fix function name * Add empty line * Fix function names * Update files/en-us/web/api/performanceresourcetiming/decodedbodysize/index.md Co-authored-by: Joshua Chen <[email protected]> * Fix function names * Fix function name * Fix function names * Fix function names * Fix function names * Fix function names * fix function names * Fix function names * Fix function names * Fix function names * Fix function names * Fix function names * Use ternary operator * Fix function names * Use method * Update files/en-us/web/api/texttrack/mode/index.md Co-authored-by: Joshua Chen <[email protected]> * Update files/en-us/web/api/performance/getentriesbytype/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance/getentriesbytype/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance/getentriesbytype/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/performance_timeline/using_performance_timeline/index.md Co-authored-by: rubiesonthesky <[email protected]> * Update files/en-us/web/api/speechsynthesisvoice/name/index.md Co-authored-by: rubiesonthesky <[email protected]> * Readd example * readd example * Add workerStart to the list * Replace for…in * Use findIndex() * Use findIndex() * Fix function names (no _) * Fix alignement + for…in * Alignment * Update files/en-us/web/api/performanceresourcetiming/transfersize/index.md Co-authored-by: Joshua Chen <[email protected]> * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Update files/en-us/web/api/performanceresourcetiming/connectstart/index.md * Use ?? * Use ?? * Remove empty space * Remove space * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Use ?? * Apply suggestions from code review * Use console.log * Use console.log * Use console.log * Use console.log * Use console.log * console.log * console.log * Apply suggestions from code review * Update index.md * Update index.md * Update index.md * Remove useless variable * Fix typo * Use findLastIndex() * Update index.md * Update index.md Co-authored-by: Joshua Chen <[email protected]> Co-authored-by: rubiesonthesky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classical
forloops are error-prone (setting the right condition, not mixing indices…) and difficult to read when used to loop on all elements of an Array-like structure.This PR changes some occurrences to use the modern
for…of, or.forEach()in some occurrences.Note that:
for…ofif I don't need the index.forEach()when I do, or on an object wherefor…ofmay not work.Array.from()instead.