Use arrow functions for anonymous functions where possible (part #9) [Last part!]#19253
Merged
Use arrow functions for anonymous functions where possible (part #9) [Last part!]#19253
Conversation
github-actions
bot
added
Content:CSS
This comment was marked as resolved.
This comment was marked as resolved.
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/http/browser_detection_using_the_user_agent/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/http/browser_detection_using_the_user_agent/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/http/browser_detection_using_the_user_agent/index.md
Outdated
Show resolved
Hide resolved
…dex.md Co-authored-by: Joshua Chen <[email protected]>
…dex.md Co-authored-by: Joshua Chen <[email protected]>
…dex.md Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
reviewed
Aug 9, 2022
Comment on lines
357
to
358
| () => { | ||
| const XHRSubmit = (function () { |
Member
There was a problem hiding this comment.
This shouldn't be wrapped in a function? It used to be top-level
Contributor
Author
There was a problem hiding this comment.
When I click Edit file, I don't see this line 357 anymore. I think this is fixed.
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/guide/audio_and_video_delivery/cross_browser_video_player/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/http/browser_detection_using_the_user_agent/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/http/browser_detection_using_the_user_agent/index.md
Outdated
Show resolved
Hide resolved
…ideo_player/index.md Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/api/xmlhttprequest/using_xmlhttprequest/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/api/xmlhttprequest/using_xmlhttprequest/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
reviewed
Aug 9, 2022
files/en-us/web/api/xmlhttprequest/using_xmlhttprequest/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
approved these changes
Aug 9, 2022
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Reviewing the diff is giving me a stomachache...
All clear now. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow functions are shorter and easier to read (but don't bind
this).This is the last part (we skipped the Learning Area though)