Use arrow functions for anonymous functions where possible (part #6)#19186
Merged
Use arrow functions for anonymous functions where possible (part #6)#19186
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Josh-Cena
reviewed
Aug 8, 2022
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
…ex.md Co-authored-by: Joshua Chen <[email protected]>
Contributor
Author
|
I think I have handled all review comments here. |
Josh-Cena
reviewed
Aug 8, 2022
Josh-Cena
reviewed
Aug 8, 2022
Josh-Cena
force-pushed
the
function-arrow-6
branch
from
15f96ad to
988dbb2
Compare
Contributor
Author
|
I think this is ready to land. |
Josh-Cena
approved these changes
Aug 8, 2022
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Yup—I was just AFK for dinner (at 10pm). All boxes are ticked for me.
Member
|
Tangentially related @teoli2003 I noticed when you click "commit suggestion" in the GitHub UI these days, the change is not always committed, and it sometimes is just silently marked as resolved without changes. I've caught that a few times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow functions are shorter and easier to read (but don't bind
this).