Skip to content

Comments

Update remaining event pages to conform to new template#18779

Merged
teoli2003 merged 4 commits intomdn:mainfrom
queengooborg:event-pages
Jul 26, 2022
Merged

Update remaining event pages to conform to new template#18779
teoli2003 merged 4 commits intomdn:mainfrom
queengooborg:event-pages

Conversation

@queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 25, 2022

This PR updates all of the remaining events to conform to the new template. This is a follow-up to #18732.

Note: the Microsoft proprietary events were skipped as #18750 is open to remove them.

@queengooborg queengooborg requested review from a team as code owners July 25, 2022 13:50
@queengooborg queengooborg requested review from sideshowbarker and removed request for a team July 25, 2022 13:50
@queengooborg queengooborg mentioned this pull request Jul 25, 2022
Merged
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Element/transitionrun_event
Title: Element: transitionrun event
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/Document/transitionrun_event redirects to /en-US/docs/Web/API/Element/transitionrun_event
    • /en-US/docs/Web/API/Window/transitionrun_event redirects to /en-US/docs/Web/API/Element/transitionrun_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/GlobalEventHandlers/ontransitionrun

URL: /en-US/docs/Web/API/Element/gestureend_event
Title: Element: gestureend event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/GestureEvent/rotation does not exist
    • /en-US/docs/Web/API/GestureEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/webkitmouseforcedown_event
Title: Element: webkitmouseforcedown event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MouseEvent/mozPressure does not exist

URL: /en-US/docs/Web/API/Element/gesturechange_event
Title: Element: gesturechange event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/GestureEvent/rotation does not exist
    • /en-US/docs/Web/API/GestureEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/transitionend_event
Title: Element: transitionend event
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/ontransitionend redirects to /en-US/docs/Web/API/Element/transitionend_event
    • /en-US/docs/Web/API/Document/transitionend_event redirects to /en-US/docs/Web/API/Element/transitionend_event
    • /en-US/docs/Web/API/Window/transitionend_event redirects to /en-US/docs/Web/API/Element/transitionend_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Window/transitioncancel_event

URL: /en-US/docs/Web/API/RTCDtlsTransport/error_event
Title: RTCDtlsTransport: error event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCDtlsTransport/onerror does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLCanvasElement/webglcontextlost_event
Title: HTMLCanvasElement: webglcontextlost event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLCanvasElement/webglcontextrestored_event
Title: HTMLCanvasElement: webglcontextrestored event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLCanvasElement/webglcontextcreationerror_event
Title: HTMLCanvasElement: webglcontextcreationerror event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/afterscriptexecute_event
Title: Element: afterscriptexecute event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitionrun_event
Title: Element: transitionrun event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/gestureend_event
Title: Element: gestureend event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/webkitmouseforcedown_event
Title: Element: webkitmouseforcedown event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/gesturechange_event
Title: Element: gesturechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/DOMActivate_event
Title: Element: DOMActivate event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitionend_event
Title: Element: transitionend event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLDialogElement/close_event
Title: HTMLDialogElement: close event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLDialogElement/cancel_event
Title: HTMLDialogElement: cancel event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCDtlsTransport/error_event
Title: RTCDtlsTransport: error event
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Markdown_in_MDN
Title: Markdown in MDN
on GitHub

No new external URLs

(this comment was updated 2022-07-26 06:38:28.435409)

teoli2003
teoli2003 suggested changes Jul 26, 2022
View reviewed changes
@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented Jul 26, 2022

@teoli2003 we've removed semicolons ; from syntax sections [ref] of all WebAPI pages, do we want them for event pages?

Also, we discussed about removing empty sections. Do we want to keep this Event Properties section in DOMActivate_event?

teoli2003
teoli2003 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 590c993 into mdn:main Jul 26, 2022
@queengooborg queengooborg deleted the event-pages branch July 26, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @OnkarRuikar @teoli2003