Remove GlobalEventHandlers (and almost all mentions of it) from MDN#18778
Conversation
queengooborg
requested review from
Josh-Cena,
Rumyra,
jpmedley and
schalkneethling
and removed request for
a team
github-actions
bot
added
Content:Accessibility
This comment was marked as resolved.
This comment was marked as resolved.
teoli2003
reviewed
Jul 25, 2022
Contributor
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
A first question here, before I review this in detail.
files/en-us/learn/javascript/building_blocks/conditionals/index.md
Outdated
Show resolved
Hide resolved
Contributor
|
🍾 |
Collaborator
Author
|
Whoo! This officially marks the completion of two big OWD projects! 🎉🎊🍾 |
yin1999
added a commit
to yin1999/translated-content
that referenced
this pull request
Sep 1, 2022
yin1999
added a commit
to mdn/translated-content
that referenced
this pull request
Sep 1, 2022
* delete for each...in error page ref: mdn/content#10793 * delete a TypeError page * Removed obsolete page: sniffing animation support ref: mdn/content#17290 * Duplicate Page Delete ref: mdn/content#17765 * Delete Glossary/DHTML ref: mdn/content#13138 * remove GlobalEventHandlers ref: mdn/content#18778 * cleanup wikihistory
yin1999
added a commit
to yin1999/translated-content
that referenced
this pull request
Sep 3, 2022
yin1999
added a commit
to mdn/translated-content
that referenced
this pull request
Sep 3, 2022
* remove XMLHttpRequest.mozResponseArrayBuffer * Remove Firefox internal canvas.drawWidgetAsOnScreen page ref: mdn/content#19706 * Remove api.Document.documentURIObject ref: mdn/content#7489 * Remove non-standard no-more-implemented children of File ref: mdn/content#8928 * Remove irrelevant FileError API ref: mdn/content#8166 * Remove PerformanceFrameTiming from MDN ref: mdn/content#9670 * Remove GlobalEventHandlers ref: mdn/content#18778 * Remove sync version of IDB API which never existed ref: mdn/content#13139 * Remove api.Text.isElementContentWhitespace ref: mdn/content#7488 * Delete TextRange ref: mdn/content#8589 * Remove UIEvent.isChar documentation ref: mdn/content#8350 * delete window.controllers ref: mdn/content#8408 * Remove Window.dialogArguments from MDN ref: mdn/content#15754 * delete window.directories ref: mdn/content#8405 * remove Window.{onmozbeforepaint, onpaint} ref: mdn/content#8244 * Remove Window.setCursor page ref: mdn/content#10694 * cleanup wikihistory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the GlobalEventHandlers mixin, as well as (almost) all mentions of it throughout MDN. A side effect of this is fixing a lot of broken links left behind from the events conversion.
Note: there are still a lot of leftover links on individual event pages. These will be fixed in #18732 and #18779.