`Function` - Rename properties and methods to include `prototype` · Pull Request #18200 · mdn/content

ghost · 2022-07-11T04:21:41Z

Summary

Renames properties such as Function.name to Function.prototype.name.

Motivation

Consistency.

Supporting details

N/A.

Related issues

Fixes #18188.

Metadata

Adds a new document
Rewrites (or significantly expands) a document
Fixes a typo, bug, or other error

github-actions · 2022-07-11T04:24:23Z

Preview URLs

Flaws

Note! 9 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function
Title: Function
on GitHub
Flaw count: 1

bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/caller
Title: Function.prototype.caller
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/JavaScript/Reference/Functions/arguments/caller does not exist

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function
Title: Function
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/arguments
Title: Function.prototype.arguments
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name
Title: Function.prototype.name
on GitHub

https://github.com/zloirock/core-js (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply
Title: Function.prototype.apply()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/length
Title: Function.prototype.length
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/displayName
Title: Function.prototype.displayName
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/toString
Title: Function.prototype.toString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/call
Title: Function.prototype.call()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind
Title: Function.prototype.bind()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/Function
Title: Function() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/caller
Title: Function.prototype.caller
on GitHub

No new external URLs

(this comment was updated 2022-07-15 10:26:45.239582)

files/en-us/web/javascript/reference/global_objects/function/tostring/index.md

files/en-us/web/javascript/reference/global_objects/function/arguments/index.md

files/en-us/web/javascript/reference/global_objects/function/call/index.md

Josh-Cena

Overall looks much better to me; mostly minor suggestions

files/en-us/web/javascript/reference/global_objects/function/apply/index.md

Josh-Cena · 2022-07-15T03:45:09Z

files/en-us/web/javascript/reference/global_objects/function/apply/index.md

+`apply` is very similar to `call()`, except for the type of arguments it supports. You use an arguments array instead of a list of arguments (parameters). With `apply`, you can also use an array literal, for example, `func.apply(this, ['eat', 'bananas'])`, or an {{jsxref("Array")}} object, for example, `func.apply(this, new Array('eat', 'bananas'))`.

-You can also use {{jsxref("Functions/arguments", "arguments")}} for the `argsArray` parameter. {{jsxref("Functions/arguments", "arguments")}} is a local variable of a function. It can be used for all unspecified arguments of the called object. Thus, you do not have to know the arguments of the called object when you use the `apply` method. You can use `arguments` to pass all the arguments to the called object. The called object is then responsible for handling the arguments.
+You can also use {{jsxref("Functions/arguments", "arguments")}} for the `argsArray` parameter. `arguments` is a local variable of a function. It can be used for all unspecified arguments of the called object. Thus, you do not have to know the arguments of the called object when you use the `apply` method. You can use `arguments` to pass all the arguments to the called object. The called object is then responsible for handling the arguments.


Frankly, I don't grasp this paragraph. Is it talking about something like this?

function foo() { bar.apply(null, arguments); }

Maybe we can merge it with the paragraph below about array-like objects, saying something like "arguments is array-like so you can pipe it through—this is equivalent to using function foo(...args) { bar(...args) }?

Yes, it seems to be redundant in that it describes being array-like, without saying "array-like."

files/en-us/web/javascript/reference/global_objects/function/displayname/index.md

files/en-us/web/javascript/reference/global_objects/function/function/index.md

files/en-us/web/javascript/reference/global_objects/function/length/index.md

files/en-us/web/javascript/reference/global_objects/function/name/index.md

Co-authored-by: Joshua Chen <[email protected]>

…pply/index.md Co-authored-by: Joshua Chen <[email protected]>

Co-authored-by: Joshua Chen <[email protected]>

…ame/index.md Co-authored-by: Joshua Chen <[email protected]>

Co-authored-by: Joshua Chen <[email protected]>

ghost · 2022-07-15T04:25:09Z

@Josh-Cena I'm still reviewing your feedback, but just to confirm, it seems like you're interested in broadening this to a light rewrite/update of Function/*?

Josh-Cena · 2022-07-15T04:27:06Z

No—I'm just dropping random thoughts as I go through the diff. I'm not particularly interested in re-writing outside the diff.

ghost · 2022-07-15T04:28:41Z

Understood, it's just that there are definitely plenty of similar issues outside of the diff.

Josh-Cena

I've done a few changes and at least the diffed regions look good enough to me.

I'm going to go ahead and merge this. Any extra modernization attempts can go into follow-up PRs.

OnkarRuikar · 2022-07-16T03:05:24Z

files/en-us/web/javascript/reference/global_objects/function/bind/index.md

-bind(thisArg, arg1)
-bind(thisArg, arg1, arg2)
-bind(thisArg, arg1, ... , argN)
+bind(thisArg, arg1, …, argN)


@phosra why did you change these?
As per the MDN Web Docs guidelines, https://developer.mozilla.org/en-US/docs/MDN/Structures/Syntax_sections#syntax_for_arbitrary_number_of_parameters , it's correct. Including the ellipsis.

We updated all the pages as per these guidelines couple of month ago.

These were done by @Josh-Cena.

Oh @OnkarRuikar I wasn't aware of that convention ^^ If you want to send a quick fix I will gladly review it.

OnkarRuikar · 2022-07-16T03:07:29Z

files/en-us/web/javascript/reference/global_objects/function/call/index.md

-call(thisArg, arg1)
-call(thisArg, arg1, arg2)
-call(thisArg, arg1, ... , argN)
+call(thisArg, arg1, …, argN)


call(thisArg, arg1, /* … ,*/ argN)

Phosra added 3 commits July 10, 2022 19:58

Update index.md

9e16f71

Update index.md

11dc3b4

Update index.md

0615fbd

github-actions bot added the Content:JS JavaScript docs label Jul 11, 2022

Phosra added 2 commits July 10, 2022 21:34

Update index.md

8276905

Update index.md

7ec56a6

Josh-Cena reviewed Jul 11, 2022

View reviewed changes

files/en-us/web/javascript/reference/global_objects/function/tostring/index.md Outdated Show resolved Hide resolved

Update index.md

e588f04

Josh-Cena reviewed Jul 11, 2022

View reviewed changes

files/en-us/web/javascript/reference/global_objects/function/arguments/index.md Outdated Show resolved Hide resolved

Phosra added 12 commits July 14, 2022 16:58

Update index.md

d4ff10e

revert toString

2eb8032

Revert call

967e7a5

Merge branch 'mdn:main' into function

bd7dbc7

Update index.md

54a77dc

Update index.md

de13d41

Update index.md

21cbc4d

Update index.md

f18fe85

Update index.md

626ca79

Shorten jsxref

5feb30d

Shorten jsxref

2155a8d

Update index.md

5a48b13

ghost commented Jul 15, 2022

View reviewed changes

files/en-us/web/javascript/reference/global_objects/function/call/index.md Outdated Show resolved Hide resolved

Phosra added 7 commits July 14, 2022 18:05

Update index.md

f0ac61d

Update index.md

403f863

Update index.md

0a36b76

Update index.md

6f7b24d

Use template string

7ef933e

Update index.md

2689d75

Update index.md

5419231

Phosra added 3 commits July 14, 2022 20:04

Fix flaw

c5a8894

Fix flaw

6b659f5

Insert missing comma

89fb45a

ghost marked this pull request as ready for review July 15, 2022 03:33

ghost self-requested a review as a code owner July 15, 2022 03:33

ghost requested review from Josh-Cena and removed request for a team July 15, 2022 03:33

Merge branch 'main' into function

62f795f

Josh-Cena requested changes Jul 15, 2022

View reviewed changes

Phosra and others added 7 commits July 14, 2022 21:12

Drop ES5

5ee45f8

Co-authored-by: Joshua Chen <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/function/a…

0716c02

…pply/index.md Co-authored-by: Joshua Chen <[email protected]>

Drop array syntax comments

c5bc2c0

Co-authored-by: Joshua Chen <[email protected]>

Update files/en-us/web/javascript/reference/global_objects/function/n…

6e33f2c

…ame/index.md Co-authored-by: Joshua Chen <[email protected]>

Update /apply note

abac147

Co-authored-by: Joshua Chen <[email protected]>

Update /bind note

b94a4c3

Update /call note

f2bdf0d

Josh-Cena added 6 commits July 15, 2022 17:02

Apply suggestions from code review

876d543

Update index.md

384d398

Update index.md

f54172b

Update index.md

d80d649

fixes

53c4a39

more fixes

2cc5630

Josh-Cena approved these changes Jul 15, 2022

View reviewed changes

Josh-Cena merged commit 10e9198 into mdn:main Jul 15, 2022

ghost deleted the function branch July 15, 2022 21:43

OnkarRuikar reviewed Jul 16, 2022

View reviewed changes

Comments

Conversation

ghost commented Jul 11, 2022

Summary

Motivation

Supporting details

Related issues

Metadata

Uh oh!

github-actions bot commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Josh-Cena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Josh-Cena Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

ghost Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jul 15, 2022

Uh oh!

Josh-Cena commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 15, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Josh-Cena left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OnkarRuikar Jul 16, 2022

Choose a reason for hiding this comment

Uh oh!

ghost Jul 16, 2022

Choose a reason for hiding this comment

Uh oh!

Josh-Cena Jul 16, 2022

Choose a reason for hiding this comment

Uh oh!

OnkarRuikar Jul 16, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jul 11, 2022 •

edited

Loading

Josh-Cena commented Jul 15, 2022 •

edited

Loading

ghost commented Jul 15, 2022 •

edited by ghost

Loading

Josh-Cena left a comment •

edited

Loading