Skip to content

Comments

#2 Make all TypedArray constructor examples consistent#17831

Merged
wbamberg merged 11 commits intomainfrom
unknown repository
Jul 1, 2022
Merged

#2 Make all TypedArray constructor examples consistent#17831
wbamberg merged 11 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 1, 2022 •
edited by ghost
Loading

Summary

Updates code examples in accordance with #17830; this is an exact copy, reapplied to the constructor files.
The "description" section of Uint16Array is moved into "Compatibility notes" section, as the others currently are.

Motivation

Consistency between examples. Also see the motivation of #17830.

Supporting details

N/A

Related issues

Blocked on #17830.

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@ghost ghost self-requested a review as a code owner July 1, 2022 01:35
@ghost ghost requested review from Josh-Cena and removed request for a team July 1, 2022 01:35
@ghost ghost changed the title #2 Make all TypedArray constructor examples consistent, remove var #2 Make all TypedArray constructor examples consistent Jul 1, 2022
@github-actions github-actions bot added the Content:JS JavaScript docs label Jul 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Float64Array/Float64Array
Title: Float64Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Int16Array/Int16Array
Title: Int16Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Int32Array/Int32Array
Title: Int32Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Int8Array/Int8Array
Title: Int8Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint32Array/Uint32Array
Title: Uint32Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/Uint8Array
Title: Uint8Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/BigUint64Array/BigUint64Array
Title: BigUint64Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Float32Array/Float32Array
Title: Float32Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint16Array/Uint16Array
Title: Uint16Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt64Array/BigInt64Array
Title: BigInt64Array() constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8ClampedArray/Uint8ClampedArray
Title: Uint8ClampedArray() constructor
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @phosra , looks good to me!

@wbamberg wbamberg merged commit 5b776a0 into mdn:main Jul 1, 2022
@ghost ghost deleted the patch-2 branch July 5, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena was automatically assigned from mdn/yari-content-javascript

Assignees

No one assigned

Labels

Content:JS JavaScript docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wbamberg