Skip to content

Improve code style of Proxy handler example #17780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Josh-Cena merged 5 commits into from
Jul 1, 2022
Merged

Improve code style of Proxy handler example #17780

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb45017
fix: missing semicolon and `function` keyword
sentyaev Jun 29, 2022
58de876
use Method definition syntax
sentyaev Jun 30, 2022
9b228bb
get rid of hungarian notation
sentyaev Jun 30, 2022
79fe15d
Update files/en-us/web/javascript/reference/global_objects/proxy/inde…
Josh-Cena Jun 30, 2022
6a8a618
Update index.md
Josh-Cena Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions files/en-us/web/javascript/reference/global_objects/proxy/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,34 +395,36 @@ Now in order to create a complete sample `traps` list, for didactic purposes, we
*/

const docCookies = new Proxy(docCookies, {
get (oTarget, sKey) {
return oTarget[sKey] || oTarget.getItem(sKey) || undefined;
get(target, key) {
return target[key] || target.getItem(key) || undefined;
},
set: function (oTarget, sKey, vValue) {
if (sKey in oTarget) { return false; }
return oTarget.setItem(sKey, vValue);
set(target, key, value) {
if (key in target) { return false; }
return target.setItem(key, value);
},
deleteProperty: function (oTarget, sKey) {
if (!sKey in oTarget) { return false; }
return oTarget.removeItem(sKey);
deleteProperty(target, key) {
if (!key in target) { return false; }
return target.removeItem(key);
},
ownKeys: function (oTarget) {
return oTarget.keys();
ownKeys(target) {
return target.keys();
},
has: function (oTarget, sKey) {
return sKey in oTarget || oTarget.hasItem(sKey);
has(target, key) {
return key in target || target.hasItem(key);
},
defineProperty: function (oTarget, sKey, oDesc) {
if (oDesc && 'value' in oDesc) { oTarget.setItem(sKey, oDesc.value); }
return oTarget;
defineProperty(target, key, descriptor) {
if (descriptor && 'value' in descriptor) {
target.setItem(key, descriptor.value);
}
return target;
},
getOwnPropertyDescriptor: function (oTarget, sKey) {
const vValue = oTarget.getItem(sKey);
return vValue ? {
value: vValue,
getOwnPropertyDescriptor(target, key) {
const value = target.getItem(key);
return value ? {
value,
writable: true,
enumerable: true,
configurable: false
configurable: false,
} : undefined;
},
});
Expand Down