Skip to content

Comments

Updated Syntax#17777

Merged
teoli2003 merged 6 commits intomdn:mainfrom
PrajwalBorkar:prajwal-patch-2
Jul 4, 2022
Merged

Updated Syntax#17777
teoli2003 merged 6 commits intomdn:mainfrom
PrajwalBorkar:prajwal-patch-2

Conversation

@PrajwalBorkar
Copy link
Contributor

@PrajwalBorkar PrajwalBorkar commented Jun 29, 2022

Summary

Replaced var with const or let as appropriate & updated spreadsheet as some files containing Var were missing in the list.

Motivation

Supporting details

Related issues

Resolving #16662

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@PrajwalBorkar PrajwalBorkar requested a review from a team as a code owner June 29, 2022 16:06
@PrajwalBorkar PrajwalBorkar requested review from sideshowbarker and removed request for a team June 29, 2022 16:06
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 29, 2022
Josh-Cena
Josh-Cena reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete reviews; the code here is written in a tricky way and some vars are actually intended.

@sideshowbarker sideshowbarker removed their request for review June 29, 2022 17:36
PrajwalBorkar and others added 4 commits June 29, 2022 23:45
@PrajwalBorkar @Josh-Cena
Updated syntax
06124c3 
Co-authored-by: Joshua Chen <[email protected]>
@PrajwalBorkar @Josh-Cena
Updated syntax
9ab8aab 
Co-authored-by: Joshua Chen <[email protected]>
@PrajwalBorkar @Josh-Cena
Updated Syntax
901ff27 
Co-authored-by: Joshua Chen <[email protected]>
@PrajwalBorkar @Josh-Cena
Updated syntax
20d2c6a 
Co-authored-by: Joshua Chen <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 31 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PluginArray
Title: PluginArray
on GitHub
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/PluginArray/length does not exist
    • /en-US/docs/Web/API/PluginArray/item does not exist
    • /en-US/docs/Web/API/PluginArray/namedItem does not exist
    • /en-US/docs/Web/API/PluginArray/refresh does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Plugins
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/PublicKeyCredentialRequestOptions
Title: PublicKeyCredentialRequestOptions
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/challenge redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/timeout redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/rpId redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/allowCredentials redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/userVerification redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • and 2 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: api.PublicKeyCredentialRequestOptions

URL: /en-US/docs/Web/API/PublicKeyCredential/getClientExtensionResults
Title: PublicKeyCredential.getClientExtensionResults()
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/PublicKeyCredentialCreationOptions/extensions redirects to /en-US/docs/Web/API/CredentialsContainer/create
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/extensions redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/extensions redirects to /en-US/docs/Web/API/CredentialsContainer/get
    • /en-US/docs/Web/API/PublicKeyCredentialCreationOptions/extensions redirects to /en-US/docs/Web/API/CredentialsContainer/create
    • /en-US/docs/Web/API/PublicKeyCredentialRequestOptions/extensions redirects to /en-US/docs/Web/API/CredentialsContainer/get

URL: /en-US/docs/Web/API/PublicKeyCredential/id
Title: PublicKeyCredential.id
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.PublicKeyCredential.id

URL: /en-US/docs/Web/API/PositionSensorVRDevice
Title: PositionSensorVRDevice
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/VRDisplay/hardwareUnitId redirects to /en-US/docs/Web/API/VRFieldOfView
    • /en-US/docs/Web/API/VRPose/hasPosition redirects to /en-US/docs/Web/API/VRPose/position
    • /en-US/docs/Web/API/VRPose/hasOrientation redirects to /en-US/docs/Web/API/VRPose/orientation

URL: /en-US/docs/Web/API/PositionSensorVRDevice/getImmediateState
Title: PositionSensorVRDevice.getImmediateState()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/VRPose/hasPosition redirects to /en-US/docs/Web/API/VRPose/position
    • /en-US/docs/Web/API/VRPose/hasOrientation redirects to /en-US/docs/Web/API/VRPose/orientation

URL: /en-US/docs/Web/API/PositionSensorVRDevice/getState
Title: PositionSensorVRDevice.getState()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/VRPose/hasPosition redirects to /en-US/docs/Web/API/VRPose/position
    • /en-US/docs/Web/API/VRPose/hasOrientation redirects to /en-US/docs/Web/API/VRPose/orientation

External URLs

URL: /en-US/docs/Web/API/PluginArray
Title: PluginArray
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Permissions_API/Using_the_Permissions_API
Title: Using the Permissions API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PresentationRequest/start
Title: PresentationRequest.start()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_Lock_API
Title: Pointer Lock API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Presentation_API
Title: Presentation API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushMessageData
Title: PushMessageData
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushMessageData/json
Title: PushMessageData.json()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushMessageData/arrayBuffer
Title: PushMessageData.arrayBuffer()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushMessageData/text
Title: PushMessageData.text()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushMessageData/blob
Title: PushMessageData.blob()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PeriodicWave/PeriodicWave
Title: PeriodicWave()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ProgressEvent
Title: ProgressEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredentialRequestOptions
Title: PublicKeyCredentialRequestOptions
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushEvent
Title: PushEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushEvent/data
Title: PushEvent.data
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushEvent/PushEvent
Title: PushEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PointerEvent/PointerEvent
Title: PointerEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PointerEvent/width
Title: PointerEvent.width
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredential
Title: PublicKeyCredential
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredential/rawId
Title: PublicKeyCredential.rawId
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredential/response
Title: PublicKeyCredential.response
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredential/getClientExtensionResults
Title: PublicKeyCredential.getClientExtensionResults()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PublicKeyCredential/id
Title: PublicKeyCredential.id
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushManager/subscribe
Title: PushManager.subscribe()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushManager/registrations
Title: PushManager.registrations()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushManager/unregister
Title: PushManager.unregister()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushManager/getSubscription
Title: PushManager.getSubscription()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushManager/register
Title: PushManager.register()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_events
Title: Pointer events
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_events/Multi-touch_interaction
Title: Multi-touch interaction
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_events/Pinch_zoom_gestures
Title: Pinch zoom gestures
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_events/Using_Pointer_Events
Title: Using Pointer Events
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PeriodicSyncManager/getTags
Title: PeriodicSyncManager.getTags()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PositionSensorVRDevice
Title: PositionSensorVRDevice
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PositionSensorVRDevice/getImmediateState
Title: PositionSensorVRDevice.getImmediateState()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PositionSensorVRDevice/getState
Title: PositionSensorVRDevice.getState()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushSubscription/toJSON
Title: PushSubscription.toJSON()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushSubscription/getKey
Title: PushSubscription.getKey()
on GitHub

No new external URLs

(this comment was updated 2022-07-03 07:47:41.704552)

@PrajwalBorkar PrajwalBorkar requested a review from Josh-Cena June 30, 2022 06:02
teoli2003
teoli2003 suggested changes Jul 2, 2022
View reviewed changes
teoli2003
teoli2003 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@teoli2003 teoli2003 merged commit b295694 into mdn:main Jul 4, 2022
@PrajwalBorkar PrajwalBorkar deleted the prajwal-patch-2 branch July 4, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PrajwalBorkar @teoli2003 @Josh-Cena