Skip to content

Comments

Removed obsolete page: sniffing animation support#17290

Merged
teoli2003 merged 2 commits intomdn:mainfrom
estelle:delete
Jun 16, 2022
Merged

Removed obsolete page: sniffing animation support#17290
teoli2003 merged 2 commits intomdn:mainfrom
estelle:delete

Conversation

@estelle
Copy link
Member

@estelle estelle commented Jun 14, 2022

Sniffing support for CSS animation with JS is no longer needed and hasn't been needed for over 5 years.

Summary

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested review from a team as code owners June 14, 2022 22:27
@estelle estelle requested review from dipikabh and removed request for a team June 14, 2022 22:27
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2022

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can go. Yeah!

@teoli2003
Copy link
Contributor

@estelle Did you use yarn content delete (docs) to delete the page? The redirect file looks broken

@teoli2003 teoli2003 self-requested a review June 15, 2022 05:14
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect file must be fixed

@estelle
Copy link
Member Author

estelle commented Jun 15, 2022 via email

@estelle
Copy link
Member Author

estelle commented Jun 15, 2022

in the meantime, i manually edited the redirectss file.

@estelle estelle requested a review from teoli2003 June 15, 2022 17:54
@teoli2003
Copy link
Contributor

For the life of me, I couldn't get yarn delete to work. So hand did the delete, and didn't touch the redirect file. This is what I put in:
yarn content delete
web/css/css_animations/detecting_css_animation_support/ --recursive with and without the --recursive and preceded by a / and not followed by a /. nothing worked

I'll review it tomorrow.

Why the yarn delete is not working: I think you need to put the same capitalization as the slug: Web/API/… (recursive is not needed) and that's likely why it is failing. (When possible, I also use the --redirect _slugname_ option so that's not a 404 after the deletion but a 30x Moved Permanently).

@estelle
Copy link
Member Author

estelle commented Jun 15, 2022

I copied the slug from the document itself, and also tried all lowercase, with slashes and without. Nothing worked. Maybe the 4 or 5 redirects in the redirect file may have been the issue.

Thanks!

@estelle
Copy link
Member Author

estelle commented Jun 16, 2022

I had the wrong version of node.
#17334 was done using yarn. I left it in draft mode as a comparison. My hand edit looks good.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this!

@teoli2003 teoli2003 merged commit e78ec71 into mdn:main Jun 16, 2022
@estelle estelle deleted the delete branch July 19, 2022 22:15
yin1999 added a commit to yin1999/translated-content that referenced this pull request Sep 1, 2022
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 1, 2022
* delete for each...in error page

ref: mdn/content#10793

* delete a TypeError page

* Removed obsolete page: sniffing animation support

ref: mdn/content#17290

* Duplicate Page Delete

ref: mdn/content#17765

* Delete Glossary/DHTML

ref: mdn/content#13138

* remove GlobalEventHandlers

ref: mdn/content#18778

* cleanup wikihistory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants