Skip to content

Comments

Update links to canvas-raycaster to point to its new location in dom-examples#17073

Closed
dipikabh wants to merge 1 commit intomdn:mainfrom
dipikabh:repo-move-canvas-raycaster
Closed

Update links to canvas-raycaster to point to its new location in dom-examples#17073
dipikabh wants to merge 1 commit intomdn:mainfrom
dipikabh:repo-move-canvas-raycaster

Conversation

@dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Jun 7, 2022

Summary

Update links for mdn/canvas-raycaster to mdn/dom-examples/canvas-raycaster

Motivation

Part of repo maintenance exercise

Related issues

PR for moving the repo: mdn/dom-examples#111
Issue tracker: mdn/mdn#193

@dipikabh dipikabh requested a review from a team as a code owner June 7, 2022 19:29
@dipikabh dipikabh requested review from sideshowbarker and removed request for a team June 7, 2022 19:29
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 7, 2022
@dipikabh dipikabh requested review from Rumyra and schalkneethling and removed request for sideshowbarker June 7, 2022 19:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/Canvas_API/A_basic_ray-caster
Title: A basic ray-caster
on GitHub

@dipikabh dipikabh changed the title Update links to canvas-rayaster to point to its new location in dom-examples Update links to canvas-raycaster to point to its new location in dom-examples Jun 7, 2022
wbamberg
wbamberg approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @dipikabh ! It looks like this repo hasn't been moved yet, so do you want to hold off merging until then?

What do you think about deleting this page and either linking directly to GitHub from https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API#guides_and_tutorials or just deleting the demo as well?

The tutorial is really not a useful tutorial and the code is very old.

@Rumyra , @teoli2003 , views?

@Rumyra
Copy link
Collaborator

Rumyra commented Jun 9, 2022

Yeh we had a little chat about it and agree - however I really like this little demo, so we decided to create mdn/museum for little demos like this (I think there are more we can remove from MDN moving forward)

@dipikabh
Copy link
Contributor Author

dipikabh commented Jun 10, 2022

Thanks @wbamberg! Like Ruth mentioned, moving the repo to mdn/museum (mdn/museum#1) instead. I'll delete this page when that lands.

1 similar comment
@dipikabh
Copy link
Contributor Author

dipikabh commented Jun 10, 2022

Thanks @wbamberg! Like Ruth mentioned, moving the repo to mdn/museum (mdn/museum#1) instead. I'll delete this page when that lands.

@dipikabh dipikabh closed this Jun 10, 2022
@dipikabh dipikabh closed this Jun 10, 2022
This was referenced Jun 13, 2022
Closed
Merged
@dipikabh dipikabh deleted the repo-move-canvas-raycaster branch September 12, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

@schalkneethling schalkneethling Awaiting requested review from schalkneethling

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dipikabh @Rumyra @wbamberg