Conversation
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
Contributor
Preview URLsFlawsNone! 🎉 External URLsURL:
|
teoli2003
approved these changes
Apr 4, 2022
Contributor
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
👍 (Even if I believe that no spec link should be outside the Specification section, this is better than the original)
Collaborator
Author
@teoli2003 Me too, but fixing that properly would be a bit more effort than I want to put in right now. IF I end up with the WASM exception handling stuff for FF100 I'll revisit some of these concepts and do it "properly". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing link did not mention traps. I believe this is the most useful definition in the spec: https://webassembly.github.io/spec/core/intro/overview.html#trap