Conversation
hamishwillee
commented
Apr 4, 2022
Contributor
Preview URLsFlawsNone! 🎉 External URLsURL:
(this comment was updated 2022-04-04 01:21:08.657626) |
sideshowbarker
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14557
The document indicated that you might use
If-Matchwith a range request to ensure that the requested range is from the same resource (true) and that if it was not from the same resource you'd get HTTP 416 error. However the specs corroborate the testing in #14557If-Matchreturns 412 if the match is false.Rangealways is preformed after a conditional. If it fails it returns 416.So in essence you'll only get 416 if the range is "bad", but from the point of view of the If-Match docs that is a bit irrelevant.
I've tidied the docs to make it clear that you always get 412 - they were written like you might get different behaviour for put vs get/head requests. Also some minor other points from the spec (e.g. related to
*).