Skip to content

Comments

Fix inconsistent titles#14622

Merged
sideshowbarker merged 2 commits intomdn:mainfrom
mfuji09:20220404-Location-titles
Apr 3, 2022
Merged

Fix inconsistent titles#14622
sideshowbarker merged 2 commits intomdn:mainfrom
mfuji09:20220404-Location-titles

Conversation

@mfuji09
Copy link
Contributor

@mfuji09 mfuji09 commented Apr 3, 2022

Summary

Fix inconsistent titles Location: XXX to Location.XXX

Motivation

I couldn't find a reason to title as so.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@mfuji09 mfuji09 requested a review from a team as a code owner April 3, 2022 16:21
@mfuji09 mfuji09 requested review from Rumyra and removed request for a team April 3, 2022 16:21
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Preview URLs

Flaws

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Location/reload
Title: Location.reload()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/Location/assign
Title: Location.assign()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/Location/replace
Title: Location.replace()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/Location/hash
Title: Location.hash
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/port
Title: Location.port
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/password
Title: Location.password
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/reload
Title: Location.reload()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/protocol
Title: Location.protocol
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/assign
Title: Location.assign()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/replace
Title: Location.replace()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/origin
Title: Location.origin
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/host
Title: Location.host
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/href
Title: Location.href
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/username
Title: Location.username
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/hostname
Title: Location.hostname
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/search
Title: Location.search
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/pathname
Title: Location.pathname
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/toString
Title: Location.toString()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Location/ancestorOrigins
Title: Location.ancestorOrigins
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 83610a7 into mdn:main Apr 3, 2022
@mfuji09
Copy link
Contributor Author

mfuji09 commented Apr 4, 2022

@sideshowbarker Thank you for correcting!

@mfuji09 mfuji09 deleted the 20220404-Location-titles branch April 4, 2022 01:39
@sideshowbarker
Copy link
Member

@sideshowbarker Thank you for correcting!

Per the norms for the site, it wasn’t completely incorrect the way you’d changed it — though that said, the site norms still have the known problem of allowing (or even preferring) incorrect syntax that misleads developers into thinking something’s a static property when it’s actually not.

But outside of that, in cases where we have something that’s actually a global object (navigator, window, location), it seems more helpful for developers if we use the actual object rather than the interface name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants