Skip to content

Comments

Replace {{event)}} with domxref (batch #3)#14582

Merged
hamishwillee merged 1 commit intomdn:mainfrom
teoli2003:remove-event-macro-3
Apr 3, 2022
Merged

Replace {{event)}} with domxref (batch #3)#14582
hamishwillee merged 1 commit intomdn:mainfrom
teoli2003:remove-event-macro-3

Conversation

@teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Apr 2, 2022

Now that we have updated events on MDN/content, we can replace {{event}} (that is ambiguous or lead to unwanted redirects) with the {{domxref}} macros.

@teoli2003 teoli2003 requested review from a team as code owners April 2, 2022 10:14
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team April 2, 2022 10:14
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Apr 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Preview URLs

Flaws

Note! 18 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub
Flaw count: 21

  • macros:
    • /en-US/docs/Web/HTML/Element/svg does not exist
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Window/appinstalled does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Responsive_Design_Mode
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Examine_grid_layouts
    • Can't resolve /en-US/docs/Tools/about:debugging#service_worker_state
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Examine_and_edit_CSS#element_rule
    • and 13 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub
Flaw count: 14

  • macros:
    • /en-US/docs/Web/CSS/align does not exist
    • /en-US/docs/Web/API/ChildNode/before redirects to /en-US/docs/Web/API/Element/before
    • /en-US/docs/Web/API/ChildNode/after redirects to /en-US/docs/Web/API/Element/after
    • /en-US/docs/Web/API/ChildNode/replaceWith redirects to /en-US/docs/Web/API/Element/replaceWith
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/EventListenerOptions does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations#further_information_about_animation_compositing
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Examine_and_edit_HTML#element_popup_context_menu
    • Can't resolve /en-US/docs/Tools/Network_Monitor
    • Can't resolve /en-US/docs/Tools/about:debugging#service_workers_not_compatible
    • Can't resolve /en-US/docs/Tools/about:debugging#tabs
    • and 4 more flaws omitted

URL: /en-US/docs/Web/Progressive_web_apps/Re-engageable_Notifications_Push
Title: How to make PWAs re-engageable using Notifications and Push
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Onclick does not exist

URL: /en-US/docs/Web/API/ServiceWorkerGlobalScope/notificationclick_event
Title: ServiceWorkerGlobalScope: notificationclick event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ServiceWorkerGlobalScope/onnotificationclick does not exist

URL: /en-US/docs/Web/API/RTCTrackEvent
Title: RTCTrackEvent
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCTrackEventInit redirects to /en-US/docs/Web/API/RTCTrackEvent/RTCTrackEvent

URL: /en-US/docs/Web/API/WebRTC_API/Using_DTMF
Title: Using DTMF with WebRTC
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/MediaConstraints does not exist
    • /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
    • /en-US/docs/Web/API/RTCPeerConnection/getTracks does not exist
    • /en-US/docs/Web/API/RTCTrackEvent/stream does not exist

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCPeerConnection/removetrack_event does not exist
    • /en-US/docs/Web/API/HTMLElement/disabled does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/Progressive_web_apps/Re-engageable_Notifications_Push
Title: How to make PWAs re-engageable using Notifications and Push
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ServiceWorkerGlobalScope/notificationclick_event
Title: ServiceWorkerGlobalScope: notificationclick event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Web_Audio_API
Title: Web Audio API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCTrackEvent
Title: RTCTrackEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/pause_event
Title: SpeechSynthesisUtterance: pause event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/end_event
Title: SpeechSynthesisUtterance: end event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/boundary_event
Title: SpeechSynthesisUtterance: boundary event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/resume_event
Title: SpeechSynthesisUtterance: resume event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/start_event
Title: SpeechSynthesisUtterance: start event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/mark_event
Title: SpeechSynthesisUtterance: mark event
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisUtterance/error_event
Title: SpeechSynthesisUtterance: error event
on GitHub

URL: /en-US/docs/Web/API/RTCPeerConnection/addTransceiver
Title: RTCPeerConnection.addTransceiver()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PushEvent/PushEvent
Title: PushEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Notification/Notification
Title: Notification()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Web_Speech_API
Title: Web Speech API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ServiceWorkerRegistration/showNotification
Title: ServiceWorkerRegistration.showNotification()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SpeechRecognitionEvent
Title: SpeechRecognitionEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SpeechRecognitionEvent/results
Title: SpeechRecognitionEvent.results
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SpeechSynthesisEvent
Title: SpeechSynthesisEvent
on GitHub

URL: /en-US/docs/Web/API/SpeechSynthesisEvent/name
Title: SpeechSynthesisEvent.name
on GitHub

URL: /en-US/docs/Web/API/WebRTC_API/Session_lifetime
Title: Lifetime of a WebRTC session
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Using_DTMF
Title: Using DTMF with WebRTC
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
on GitHub

No new external URLs

hamishwillee
hamishwillee reviewed Apr 3, 2022
View reviewed changes
files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md
- : This handler for the {{domxref("RTCPeerConnection.track_event", "track")}} event is called by the local WebRTC layer when a track is added to the connection. This lets you connect the incoming media to an element to display it, for example. See [Receiving new streams](#receiving_new_streams) for details.
- {{domxref("RTCPeerConnection.negotiationneeded_event", "onnegotiationneeded")}}
- : This function is called whenever the WebRTC infrastructure needs you to start the session negotiation process anew. Its job is to create and send an offer, to the callee, asking it to connect with us. See [Starting negotiation](#starting_negotiation) to see how we handle this.
- {{domxref("RTCPeerConnection.removetrack_event", "onremovetrack")}}
Copy link
Collaborator

@hamishwillee hamishwillee Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one might be https://developer.mozilla.org/en-US/docs/Web/API/MediaStream/removetrack_event

Suggested change
- {{domxref("RTCPeerConnection.removetrack_event", "onremovetrack")}}
- {{domxref("MediaStream.removetrack_event", "removetrack")}}

But actually ignore, I see you are working through these batch-wise

hamishwillee
hamishwillee approved these changes Apr 3, 2022
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.
There are a bunch of incorrect event links which we should fix up but that's a separate task.

@hamishwillee hamishwillee merged commit ddb8a71 into mdn:main Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra was automatically assigned from mdn/yari-content-web-api

Assignees

No one assigned

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teoli2003 @hamishwillee