Replace {{event)}} with domxref (batch #2) by teoli2003 · Pull Request #14578 · mdn/content

teoli2003 · 2022-04-02T07:39:19Z

Now that we have updated events on MDN/content, we can replace {{event}} (that is ambiguous or lead to unwanted redirects) with the {{domxref}} macros.

github-actions · 2022-04-02T07:41:44Z

Preview URLs

Flaws

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/40
Title: Firefox 40 for developers
on GitHub
Flaw count: 21

macros:
- /en-US/docs/Web/API/NavigatorID/taintEnabled redirects to /en-US/docs/Web/API/Navigator/taintEnabled
- /en-US/docs/Web/API/DataStore does not exist
broken_links:
- Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations#firefox_40
- Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Examine_and_edit_CSS#get_help_for_css_properties
- Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Edit_CSS_filters
- Can't resolve /en-US/docs/Tools/Web_Console#console_api_messages
- Can't resolve /en-US/docs/Tools/Network_Monitor#filtering_by_url
- and 14 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub
Flaw count: 24

macros:
- /en-US/docs/Web/CSS/-moz-math-display does not exist
- /en-US/docs/Web/CSS/-moz-window-shadow does not exist
- /en-US/docs/Web/CSS/@page/marks does not exist
- /en-US/docs/Web/CSS/page does not exist
- /en-US/docs/Web/CSS/size does not exist
- and 11 more flaws omitted
broken_links:
- Can't resolve /en-US/docs/Tools/Memory
- Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
- Can't resolve /en-US/docs/Tools/Performance/Waterfall#markers
- Can't resolve /en-US/docs/Mozilla/Add-ons/Firefox_for_Android/API/Snackbars.jsm
- Can't resolve /en-US/docs/Mozilla/Firefox_for_Android
- and 3 more flaws omitted

URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/PaymentMethodData does not exist
bad_bcd_queries:
- No BCD data for query: api.AddressErrors

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/PaymentMethodChangeEvent
Title: PaymentMethodChangeEvent
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/API/PaymentMethodChangeEventInit does not exist

URL: /en-US/docs/Web/API/RTCPeerConnectionIceEvent
Title: RTCPeerConnectionIceEvent
on GitHub
Flaw count: 1

bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub
Flaw count: 3

macros:
- /en-US/docs/Web/API/RTCTransportStats does not exist
broken_links:
- Anchor not lowercase
bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/API/RTCIceCandidateStats/url
Title: RTCIceCandidateStats.url
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/API/RTCPeerConnectionIceEvent/url does not exist

URL: /en-US/docs/Web/API/WebRTC_API
Title: WebRTC API
on GitHub
Flaw count: 4

macros:
- /en-US/docs/Web/API/RTCDtlsTransport/statechange_event does not exist
- /en-US/docs/Web/API/RTCSctpTransport/statechange_event does not exist
- /en-US/docs/Web/API/RTCIdentityProvider does not exist
- /en-US/docs/Web/API/RTCIdentityProviderRegistrar does not exist

URL: /en-US/docs/Web/API/WebRTC_API/Using_DTMF
Title: Using DTMF with WebRTC
on GitHub
Flaw count: 4

macros:
- /en-US/docs/Web/API/MediaConstraints does not exist
- /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
- /en-US/docs/Web/API/RTCPeerConnection/getTracks does not exist
- /en-US/docs/Web/API/RTCTrackEvent/stream does not exist

URL: /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
Title: A simple RTCDataChannel sample
on GitHub
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Archive/Web/JavaScript/New_in_JavaScript/ECMAScript_2015_support_in_Mozilla

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/RTCPeerConnection/removetrack_event does not exist
- /en-US/docs/Web/API/HTMLElement/disabled does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/40
Title: Firefox 40 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AddressErrors
Title: AddressErrors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCRtpTransceiver/stop
Title: RTCRtpTransceiver.stop()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCRtpTransceiver/direction
Title: RTCRtpTransceiver.direction
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/methodName
Title: PaymentMethodChangeEvent.methodName
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/PaymentMethodChangeEvent
Title: PaymentMethodChangeEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentMethodChangeEvent/methodDetails
Title: PaymentMethodChangeEvent.methodDetails
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStreamEvent
Title: MediaStreamEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStreamEvent/stream
Title: MediaStreamEvent.stream
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/payerdetailchange_event
Title: PaymentResponse: payerdetailchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnectionIceEvent
Title: RTCPeerConnectionIceEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCPeerConnectionIceEvent/candidate
Title: RTCPeerConnectionIceEvent.candidate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats/url
Title: RTCIceCandidateStats.url
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport
Title: RTCIceTransport
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport/selectedcandidatepairchange_event
Title: RTCIceTransport: selectedcandidatepairchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport/getLocalCandidates
Title: RTCIceTransport.getLocalCandidates()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport/statechange_event
Title: RTCIceTransport: statechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport/getSelectedCandidatePair
Title: RTCIceTransport.getSelectedCandidatePair()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceTransport/gatheringstatechange_event
Title: RTCIceTransport: gatheringstatechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API
Title: WebRTC API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Using_DTMF
Title: Using DTMF with WebRTC
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
Title: A simple RTCDataChannel sample
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Using_data_channels
Title: Using WebRTC data channels
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Intro_to_RTP
Title: Introduction to the Real-time Transport Protocol (RTP)
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
on GitHub

No new external URLs

(this comment was updated 2022-04-04 05:07:07.972031)

hamishwillee · 2022-04-04T00:19:27Z

files/en-us/web/api/paymentresponse/payerdetailchange_event/index.md

 ## Examples

-In the example below, `onpayerdetailchange` is used to set up a listener for the {{event("payerdetailchange")}} event in order to validate the information entered by the user, requesting that any mistakes be corrected
+In the example below, `onpayerdetailchange` is used to set up a listener for the {{domxref("PaymentRequest.payerdetailchange_event", "payerdetailchange")}} event in order to validate the information entered by the user, requesting that any mistakes be corrected


Is PaymentRequest.payerdetailchange_event correct? It's giving a macro error and not listed in the parent page or BCD for PaymentRequest.

Good catch, it is PaymentResponse. Even more, it is a link to the very same page it is on. I'm transforming it not to be a link.

hamishwillee

Looks great. Approving, but not merging to give you a chance to look at #14578 (comment)

And of course resolving the conflicts :-(

teoli2003 · 2022-04-04T05:04:59Z

Thanks: I fixed the two conflicts, and did the fix for the broken link.

Replace {{event)}} with domxref

f3f85ae

teoli2003 requested review from a team as code owners April 2, 2022 07:39

teoli2003 requested review from Rumyra and removed request for a team April 2, 2022 07:39

github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Apr 2, 2022

icegatherstatechange

146b189

hamishwillee reviewed Apr 4, 2022

View reviewed changes

hamishwillee approved these changes Apr 4, 2022

View reviewed changes

teoli2003 added 2 commits April 4, 2022 07:01

Fix payerdetailchange event.

9e60732

Merge branch 'main' into remove-event-macro-2

ec483a3

teoli2003 merged commit ce44990 into mdn:main Apr 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Replace {{event)}} with domxref (batch #2)#14578

Replace {{event)}} with domxref (batch #2)#14578
teoli2003 merged 4 commits intomdn:mainfrom
teoli2003:remove-event-macro-2

teoli2003 commented Apr 2, 2022

Uh oh!

github-actions bot commented Apr 2, 2022 •

edited

Loading

Uh oh!

hamishwillee Apr 4, 2022

Uh oh!

teoli2003 Apr 4, 2022 •

edited

Loading

Uh oh!

hamishwillee left a comment •

edited

Loading

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

teoli2003 commented Apr 2, 2022

Uh oh!

github-actions bot commented Apr 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview URLs

Flaws

External URLs

Uh oh!

hamishwillee Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

teoli2003 Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hamishwillee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teoli2003 commented Apr 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 2, 2022 •

edited

Loading

teoli2003 Apr 4, 2022 •

edited

Loading

hamishwillee left a comment •

edited

Loading