Skip to content

Comments

Remove event macro (batch #1)#14501

Merged
Elchi3 merged 4 commits intomdn:mainfrom
teoli2003:remove-event-macro-1
Apr 1, 2022
Merged

Remove event macro (batch #1)#14501
Elchi3 merged 4 commits intomdn:mainfrom
teoli2003:remove-event-macro-1

Conversation

@teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Mar 31, 2022

Now that we have updated events on MDN/content, we can replace {{event}} (that is ambiguous or lead to unwanted redirects) with the {{domxref}} macros.

I'm doing this in batches, this is a test one. And I'm starting with events that are linked to one single interface.

@teoli2003 teoli2003 requested review from a team as code owners March 31, 2022 09:52
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team March 31, 2022 09:52
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Mar 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/59
Title: Firefox 59 for developers
on GitHub
Flaw count: 13

  • macros:
    • /en-US/docs/Web/CSS/-moz-border-top-colors does not exist
    • /en-US/docs/Web/CSS/-moz-border-right-colors does not exist
    • /en-US/docs/Web/CSS/-moz-border-bottom-colors does not exist
    • /en-US/docs/Web/CSS/-moz-border-left-colors does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Network_Monitor
    • Can't resolve /en-US/docs/Tools/Network_Monitor#html_preview
    • Can't resolve /en-US/docs/Tools/Storage_Inspector#cookies
    • Can't resolve /en-US/docs/Tools/Rulers
    • Can't resolve /en-US/docs/Tools/Responsive_Design_Mode
    • and 4 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/18
Title: Firefox 18 for developers
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIStreamListener does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIUploadChannel does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIEditor does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIEditorObserver does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIHttpProtocolHandler does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/Performance/Fundamentals
Title: Performance fundamentals
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Tools/Network_Monitor
    • Can't resolve /en-US/docs/Tools/Performance
    • Can't resolve /en-US/docs/Performance/Profiling_with_the_Built-in_Profiler
    • Can't resolve /en-US/docs/Tools/Remote_Debugging
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/MediaRecorder
Title: MediaRecorder
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaRecorder/onwarning redirects to /en-US/docs/Web/API/MediaRecorder/warning_event

URL: /en-US/docs/Web/API/MediaRecorder/start
Title: MediaRecorder.start()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/MediaRecorder/dataavailable does not exist
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/MediaRecorder/dataavailable_event
Title: MediaRecorder: dataavailable event
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/MediaRecorder/requestData
Title: MediaRecorder.requestData()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Dataavailable does not exist
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/SourceBuffer/changeType
Title: SourceBuffer.changeType()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaSource/sourceopen_event does not exist

URL: /en-US/docs/Web/API/Intersection_Observer_API/Timing_element_visibility
Title: Timing element visibility with the Intersection Observer API
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

URL: /en-US/docs/Web/API/MediaStreamTrack/muted
Title: MediaStreamTrack.muted
on GitHub
Flaw count: 8

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 3 more flaws omitted

URL: /en-US/docs/Web/API/Navigator/sendBeacon
Title: Navigator.sendBeacon()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/MediaStream_Recording_API
Title: MediaStream Recording API
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/IDBVersionChangeEvent
Title: IDBVersionChangeEvent
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/IDBDatabase/onversionchange

URL: /en-US/docs/Web/API/Payment_Request_API/Concepts
Title: Payment processing concepts
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/BasicCardRequest does not exist
    • /en-US/docs/Web/API/BasicCardRequest does not exist
    • /en-US/docs/Web/API/BasicCardResponse does not exist
  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/API/Media_Streams_API
Title: Media Capture and Streams API (Media Stream)
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/MediaDeviceKind does not exist
    • /en-US/docs/Web/API/MediaTrackCapabilities does not exist
    • /en-US/docs/Web/API/NavigatorUserMedia does not exist
    • /en-US/docs/Web/API/NavigatorUserMediaError does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/59
Title: Firefox 59 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/18
Title: Firefox 18 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/Performance/Fundamentals
Title: Performance fundamentals
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder
Title: MediaRecorder
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/start
Title: MediaRecorder.start()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/dataavailable_event
Title: MediaRecorder: dataavailable event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/requestData
Title: MediaRecorder.requestData()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorder/error_event
Title: MediaRecorder: error event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SourceBuffer/changeType
Title: SourceBuffer.changeType()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Intersection_Observer_API/Timing_element_visibility
Title: Timing element visibility with the Intersection Observer API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStreamTrack/muted
Title: MediaStreamTrack.muted
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Navigator/sendBeacon
Title: Navigator.sendBeacon()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStream_Recording_API
Title: MediaStream Recording API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaStream_Recording_API/Recording_a_media_element
Title: Recording a media element
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/IDBVersionChangeEvent
Title: IDBVersionChangeEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest
Title: PaymentRequest
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MerchantValidationEvent
Title: MerchantValidationEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MerchantValidationEvent/complete
Title: MerchantValidationEvent.complete()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MerchantValidationEvent/MerchantValidationEvent
Title: MerchantValidationEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Payment_Request_API/Concepts
Title: Payment processing concepts
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Media_Streams_API
Title: Media Capture and Streams API (Media Stream)
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaRecorderErrorEvent/error
Title: MediaRecorderErrorEvent.error
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Page_Visibility_API
Title: Page Visibility API
on GitHub

No new external URLs

(this comment was updated 2022-03-31 10:27:07.170949)

@teoli2003 teoli2003 requested a review from Elchi3 April 1, 2022 06:34
@Elchi3 Elchi3 merged commit ac7a7a7 into mdn:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra was automatically assigned from mdn/yari-content-web-api

Assignees

No one assigned

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teoli2003 @Elchi3