Replace use of XSS-prone innerHTML with safe textContent#14476
Conversation
Contributor
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
teoli2003
approved these changes
Mar 30, 2022
Contributor
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
Thank you! Good catch!
Contributor
|
Thanks a lot! Looks good to me. Congratulations upon your first merged commit here! Welcome aboard! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change is equivalent. However, it replaces an XSS-prone API (
innerHTML) with a safe API (textContent)Motivation
To encourage good web citizenship :)
Supporting details
Related issues
Metadata